[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45704618 I've implement this patch, only cause it's 100% relates with official documentation. --- If your project is set up for it, you can reply to this email and have your

Apachecon in budapest ?

2014-06-10 Thread Kristian Rosenvold
I've been considering attending apachecon in Budapest, and I would be really interested in creating a meet up to discuss "future maven" (for one or more days). It would be interesting to see if we'd be capable of using such an occasion to determine a little more about the "big picture" future of ma

Re: Release Maven 3.1.1

2014-06-10 Thread Kristian Rosenvold
How does 3.1.1 compare to 3.1.0 for your project ? Kristian 11. Juni 2014 05:03 skrev "James Mao" følgende: > Why Maven 3.1.1 is much faster than 3.0.X, what was the fix in the release? > > > > -- > View this message in context: > http://maven.40175.n5.nabble.com/Release-Maven-3-1-1-tp5765942p5

Re: Release Maven 3.1.1

2014-06-10 Thread James Mao
Why Maven 3.1.1 is much faster than 3.0.X, what was the fix in the release? -- View this message in context: http://maven.40175.n5.nabble.com/Release-Maven-3-1-1-tp5765942p5795322.html Sent from the Maven Developers mailing list archive at Nabble.com. --

Re: MNG-3106 implemented profile activation incorrectly

2014-06-10 Thread Paul Benedict
No problem for me. While you are at it, the Maven Release notes on the website (if it exists yet for the upcoming version) should probably get a "compatibility issue" note about this. Cheers, Paul On Tue, Jun 10, 2014 at 5:25 PM, Jason van Zyl wrote: > I'm working on a PR for http://jira.code

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45681556 I have argued on the Maven dev list to process your patch. The current implementation I believe to be incorrect. --- If your project is set up for it, you can reply to thi

MNG-3106 implemented profile activation incorrectly

2014-06-10 Thread Jason van Zyl
I'm working on a PR for http://jira.codehaus.org/browse/MNG-4565, which is related to what happened in http://jira.codehaus.org/browse/MNG-3106 in that profiles with multiple activators undergo an OR instead of an AND. If you want OR behaviour you can specify multiple profiles each with a single

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45673757 I'm looking for a way to make this work, but this breaks MNG-3106 where the current behaviour is to OR the activators. I agree there are cases where AND is preferable but I

[GitHub] maven-surefire pull request: Fix formatting and spelling mistakes ...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven-surefire/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread cstamas
Github user cstamas commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-45644872 FTR, Manually merged as 18964baa25e9c071d13186e4c03e3957b9381961 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] maven-integration-testing pull request: MNG-5640: IT that verifies...

2014-06-10 Thread cstamas
Github user cstamas closed the pull request at: https://github.com/apache/maven-integration-testing/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/20 [MNG-4565] Multiple profile activation conditions does not work Add possibilty to use multiple activators and have AND between them You can merge this pull request into a Git repository by runni

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45644286 Sorry, cut and paste error on my part when closing the other issues. Can you reopen the PR again and I'll process it this afternoon. --- If your project is set up for it,

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45643803 I'm sorry, I don't understand, why you close this PR? Does it bad? I miss something? --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: [MNG-5613] fix NullPointerException when error...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: [MNG-5613] Avoid NPE when dependency graph cre...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: MNG-5639: Support resolution of Import Scope P...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: MNG-4226 Detect JAVA_HOME on newer Mac OS X

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] maven pull request: Version ranges with non-snapshot bounds can co...

2014-06-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/maven/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] maven pull request: MNG-5639: Support resolution of Import Scope P...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/17#issuecomment-45641645 Patch applied, thanks. Can you close your pull request please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-45641594 Can you close your pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: How do we close pull requests?

2014-06-10 Thread Daniel Kulp
Or file a ticket with INFRA to have them closed. Or add a comment to the pull request to say “please close this” and hopefully the person who submitted it would close it. Dan On Jun 10, 2014, at 8:54 AM, Benson Margulies wrote: > you make a commit with a comment that instructs the daem

Re: How do we close pull requests?

2014-06-10 Thread Jason van Zyl
You have to pollute the commit history to remove a rejected PR? Really? On Jun 10, 2014, at 8:54 AM, Benson Margulies wrote: > you make a commit with a comment that instructs the daemon to close > it, as per Dan Kulp's email the other day. > > On Tue, Jun 10, 2014 at 8:52 AM, Jason van Zyl wro

Re: How do we close pull requests?

2014-06-10 Thread Benson Margulies
you make a commit with a comment that instructs the daemon to close it, as per Dan Kulp's email the other day. On Tue, Jun 10, 2014 at 8:52 AM, Jason van Zyl wrote: > How do we get access to close pull requests? These are just requests that are > rejected and I'd like to get rid of them. > > Tha

[GitHub] maven pull request: MNG-5639: Support resolution of Import Scope P...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/17#issuecomment-45609304 Accompanying Maven IT can be found here: https://github.com/apache/maven-integration-testing/pull/4 --- If your project is set up for it, you can reply to this email and h

How do we close pull requests?

2014-06-10 Thread Jason van Zyl
How do we get access to close pull requests? These are just requests that are rejected and I'd like to get rid of them. Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io -

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-06-10 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-45608955 Patch applied, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe