[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45138360 Cool, I'll take a look at look at the specific IT failure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45134460 I've update pull request. I change my approach, so it will not now a platform dependable. But ITs are still failing at weird place. I'm 100% sure, that it's not my fa

Re: Thoughts on MNG-3522

I am not sure xml attributes are necessary a hack. Whether to put before/after hints into xml element or attribute is really a matter of taste, imho. I don't want to restart the whole "pom v 5" discussion again, but I was under impression we agreed to preserve format published to maven repository

Re: Thoughts on MNG-3522

Thanks for your reply Jason. So it seems there are some possibilities for this ticket: either interpreting the to infer order (the patch) or stuffing this into an attribute (per Igor). Regarding the latter, the attribute route is clearly to avoid adding a new POM element, but aren't both a bit "h

Re: Thoughts on MNG-3522

I'm opposed to random creation of a DAG for executions across all the phases. This just creates a giant mess. That said _within_ a given phase if there was a topological sorting of executions where one execution can state that it depends on another I think is reasonable. Definitive ordering with

[GitHub] maven-scm pull request: [SCM-682] Maven release fails when releasi...

GitHub user mrshoki opened a pull request: https://github.com/apache/maven-scm/pull/15 [SCM-682] Maven release fails when releasing from a named branch Applying patch suggested by Esteban Porcelli, consisting in overriding HgConsumer.consumeLine method, which removes characters when

Re: Thoughts on MNG-3522

Maven 1.x was before my time :-) Can somebody recap the reasons ordering executions within a phase was decided harmful? -- Regards, Igor On 2014-06-04, 10:22, Paul Benedict wrote: I find that solution interesting because, in a way, it kind of returns us to the days of Maven 1.x where you can ru

Re: ETA for maven-scm 1.10 ?

Sorry for the lag. 1.9.1 would be perfect anyway :). Though my other message also shows I actually missed a step :). Thanks 2014-06-02 19:36 GMT+02:00 Robert Scholte : > > Hi, > > Looks more like a 1.9.1 to me[1] > > There are still some issues open which were marked to be fixed with 1.10[2] > >

SCM-741 followup and ValidateMojo requiresProject=false

Hi all, I've just discovered something with Maven that was not obvious to me. As this seems a wee bit weird, I wanted to ask here about the behaviour. I was unaware that, IIUC: *"Mojos declaring requiresProject=false, even when ran inside a multimodule project, will actually run non recursively".

Re: [GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

Any update for this PR? Please let me know if have any concerns. Regards Simon On Jun 2, 2014, at 10:16 PM, Wang, Simon wrote: > Thanks for your comments, Karl! > > I added document for this rule, please review it. > https://github.com/apache/maven-enforcer/pull/13 > > About enhance the rule

Re: Thoughts on MNG-3522

I find that solution interesting because, in a way, it kind of returns us to the days of Maven 1.x where you can run things pre/post goal. I am pretty sure Jason wanted to get rid of that perspective with this 2.x design, but maybe things are coming full circle? Cheers, Paul On Wed, Jun 4, 2014

Re: Thoughts on MNG-3522

Yes, I was also thinking before/after as a way to solve this. We can probably use xml attributes without breaking compat with artifact consumers, so I think this can be done in Maven 3.x. -- Regards, Igor On 2014-06-04, 10:09, Robert Scholte wrote: Hi Paul, that's my understanding as well. But

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

Github user pbenedict commented on the pull request: https://github.com/apache/maven/pull/19#issuecomment-45096124 Personally I prefer "osgi-bundle" too, but the argument is moot since new types are not being allowed into core. I agree with Jason. Jason's direction should allow Maven

Re: Thoughts on MNG-3522

Yes, I do think plugins should have some sort of "ordinal" value associated to them. However, I am not sure if I like the proposed patch because it infers the order out of the plugin's attribute (ex: step1, step2). Certainly such a feature could work, but it hits that wall in Maven development lan

Re: Thoughts on MNG-3522

Hi Paul, that's my understanding as well. But even in a single pom you can have issues. Consider 2 plugins, with both 2 goals and you want to run it like (phase=pre-integration-test) pluginA:preSomething pluginB:preStuff (phase=post-integration-test) pluginB:postStuff pluginA:postSomething Sin

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/19#issuecomment-45094640 That looks like a documentation issue - I believe the line from the dependency plugin doc should read: ``` -Dartifact=groupId:artifactId:version[:type][:classifier]

Re: Thoughts on MNG-3522

I haven't looked at the patch, but I know at least one case when it'd be nice to have explicit control over execution order within a build phase. Lets say you have two plugins, plugin-a with two goals a1 and a2, and plugin-b with goal b1. It is currently not possible to express the following exec

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

Github user basovnik commented on the pull request: https://github.com/apache/maven/pull/19#issuecomment-45094172 I understand your reasons but there is a little conflict with [dependency plugin](http://maven.apache.org/plugins/maven-dependency-plugin/get-mojo.html#artifact). ```

Thoughts on MNG-3522

Anyone have thoughts on this ticket? There is a submitted patch, as the last comment says -- it's part of another ticket that was marked as duplicate. Though, I am a bit confused. I thought plugin execution was already defined by the sequential order listed in the POM. Am I incorrect? If so, I sti

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/19#issuecomment-45084215 -1. This will not be pulled into the core. We need to go the other direction and take these specific packaging types out of the core. Using a plugin declaration with extens

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

Github user basovnik commented on the pull request: https://github.com/apache/maven/pull/19#issuecomment-45078998 It may be more clear and precise, but ```bundle``` type is already being used ([7300+](http://search.maven.org/#search|ga|1|p%3A%22bundle%22) times). As far as I know, ```

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/19#issuecomment-45076095 Isn't `bundle` too general? `osgi-bundle` would be clear and precise. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

GitHub user basovnik opened a pull request: https://github.com/apache/maven/pull/19 [MNG-5642] Support type 'bundle' with extension 'jar' https://jira.codehaus.org/browse/MNG-5642 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ba

Early Access builds for JDK 9 b15, JDK 8u20 b16 are available on java.net

Hi Robert,Kristian, Early Access builds for JDK 9 b15 , JDK 8u20 b16 are available on java.net. As we enter the later phases of development for JDK 8u20 , please log any show stoppers as soon as possible. JDK 7u60 is av