Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44757042
I'm 100% don't wanna rush. I will think about special activator for testing
purpose (It could be _AlwaysTrueActivator_). I will try to give it a try
tomorrow.
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756700
Maybe creating an activator specifically for testing this might be better.
I will take a look as soon as I can. Likely tomorrow. Thanks for your patience,
we'll get this in
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756676
I will take a look as soon as I can. Maybe making an activator specifically
for helping us test this will be better. Thanks for being patient, we'll get
this sorted and int
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756590
Not understand your point about failing against master.
I agree that platform activators is not good idea. So same with JDK
activator, right? I'm only left wi
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44756291
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9;
2014-02-14T12:37:52-05:00)
Maven home: /Users/jvanzyl/m2
Java version: 1.7.0_21, vendor: Oracle Corpora
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44755927
Awesome,this is the only platform, I couldn't test against.Could you
specify your _mvn -version_ output? I will try to fix test.
---
If your project is set up for it
Github user jvanzyl commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44755377
I used Maven, master branch at revision
73d35ba9597cd867717310ae8813376888debb9b. I applied your patch to master, and
ran the tests with Maven 3.2.1 on OSX.
---
If your p
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44751378
Could you tell me, what did you use?
I've run tests on Linux:
mvn -version
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-
On May 31, 2014, at 11:05 AM, Baptiste Mathus wrote:
> Hi,
>
> What do you mean by "squashing" commits?
>
That a pull request should consist of a single, coherent commit. So during the
development of the pull request it may consist of several commits but in its
final form it needs to be a si
Hi,
What do you mean by "squashing" commits?
Do you mean:
* intermediate crappy/local commits that were incorrectly pushed as-is
without having been "rebased interactively" to provide a clean and
understandable history (see the link provided by Hervé as an example)
* or that any PR should be squ
I applied your changes and your test fails. If you want to take look and
validate I will take a look later in the weekend.
---
T E S T S
---
Running org.apache.maven.model.building.ComplexActi
Github user MysterionRise commented on the pull request:
https://github.com/apache/maven/pull/16#issuecomment-44749028
Any updates on my pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Le samedi 31 mai 2014 13:55:47 Hervé BOUTEMY a écrit :
> logical, finally: why would the plugin classpath contain actual project?
>
> And since resolution happens from workspace, I imagine that the plugin can
> get classes just after compile phase, isn't it?
s/workspace/reactor/
>
> Regards,
>
logical, finally: why would the plugin classpath contain actual project?
And since resolution happens from workspace, I imagine that the plugin can get
classes just after compile phase, isn't it?
Regards,
Hervé
Le samedi 31 mai 2014 12:46:34 Tony Chemit a écrit :
> On Sat, 31 May 2014 11:19:57
On Sat, 31 May 2014 11:19:57 +0200
Hervé BOUTEMY wrote:
> you mean you're trying to do something like plexus:components-report [1]?
Yes
>
> are you sure you generated the plexus descriptor before running the mojo
> injecting implementations?
Yes,
project/target/classes/META-INF/plexus/compon
http://java.dzone.com/articles/squashing-github-pull-requests ?
Regards,
Hervé
Le vendredi 30 mai 2014 09:57:18 Jason van Zyl a écrit :
> I'm happy to look at pull requests but in the future can anyone making a
> pull request please squash your commits before making the pull request.
>
> Eventu
you mean you're trying to do something like plexus:components-report [1]?
are you sure you generated the plexus descriptor before running the mojo
injecting implementations?
Regards,
Hervé
[1] http://plexus.codehaus.org/plexus-maven-plugin/components-report-mojo.html
Le samedi 31 mai 2014 10:
Hi,
Let me explain my problem, hopes to find here a solution about it.
I am currently writing a maven report to describe some plexus components.
The idea is to be able to describe the components declared in the very same
maven module.
I tried this, it found components of the same role from the
18 matches
Mail list logo
