Re: Release of Maven Sources Plugin 2.3

2012-10-10 Thread Mark Struberg
+1 Der are quite some utility methods which return null and others which return empty strings or Collections.EMPTY. But we are not consistent in what we do. jsr-305 would at least make it obvious. LieGrue, strub - Original Message - > From: Kristian Rosenvold > To: Maven Developers

Re: Release of Maven Sources Plugin 2.3

2012-10-10 Thread Kristian Rosenvold
Ooo. Findbugs does some serious good stuff; Look at this violation in "FileUtils"; https://analysis.apache.org/drilldown/violations/12409?rids%5B%5D=103768&rids%5B%5D=103771&rule=findbugs%3ARCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE&rule_sev=CRITICAL# Which raises the question; I would never be abl

Re: Flipping Maven Core to Git

2012-10-10 Thread Mark Struberg
Kristian, wait a bit. What if we first merge the 2 repos into 1 git repo? Imo maven-core and the ITs must fit together! Having the ITs in a separate repo will make people forget about them. Also for a maven-core release it isn't a problem if the ITs get tagged. I actually would even really app

Re: SLF4J integration

2012-10-10 Thread Mark Struberg
Hi Ceki, thanks for the reply! >The method signatures of classes in the org.slf4j package such as
 >Logger, LoggerFactory, Marker, MDC, etc. are the same since 2005.
 No they are not. I did a diff between 1.2 and the latest and it seems a few trace() methods got added. This is only a minor pro

Re: Flipping Maven Core to Git

2012-10-10 Thread Kristian Rosenvold
Jason ran the tests based off the git repo and they were fine. There is no problem (I've had my fair share of troubles with the core it's so it's probably been a problem between chair and keyboard). Unless someone objects I'll file a INFRA jira to port m3-core + IT's sometime later today. Kristia

Re: Flipping Maven Core to Git

2012-10-10 Thread Anders Hammar
So, what is the solution to fixing the ITs that depend on an empty folder? Put some dummy file there? But then the folder will not be empty... /Anders On Thu, Oct 11, 2012 at 6:18 AM, Kristian Rosenvold wrote: > So you're going to be working on the core without touching the it's? > > Seriously,

Re: svn commit: r1396476 - in /maven/doxia/doxia-tools/trunk: doxia-book-maven-plugin/pom.xml doxia-converter/pom.xml

2012-10-10 Thread Kristian Rosenvold
I was building this on a clean machine with no maven repo and only maven central access. This was the only version that seemed to be available to me; it looks like the reactor-version...? I am actually a bit confused as to what *is* the correct version number ? 1.3-SNAPSHOT is nowhere to be seen ;

Re: Flipping Maven Core to Git

2012-10-10 Thread Kristian Rosenvold
So you're going to be working on the core without touching the it's? Seriously, this discussion is going nowhere. We move both and someone speeds 45 minutes fixing the it's. Kristian Den 11. okt. 2012 kl. 00:54 skrev Jason van Zyl : > I think we can flip the core, we can still release the core

Re: Flipping Maven Core to Git

2012-10-10 Thread Jason van Zyl
I think we can flip the core, we can still release the core without flipping the integration tests. It might actually be better to not move both of those at the same time. On Oct 10, 2012, at 2:36 PM, Kristian Rosenvold wrote: > It's just two simple projects that have some very simple fixes

Re: svn commit: r1396476 - in /maven/doxia/doxia-tools/trunk: doxia-book-maven-plugin/pom.xml doxia-converter/pom.xml

2012-10-10 Thread Dennis Lundberg
Committed a bit too much? See below... On 2012-10-10 07:42, krosenv...@apache.org wrote: > Author: krosenvold > Date: Wed Oct 10 05:42:44 2012 > New Revision: 1396476 > > URL: http://svn.apache.org/viewvc?rev=1396476&view=rev > Log: > o Made it compile with maven3 > > Modified: > maven/doxia

Re: Release of Maven Sources Plugin 2.3

2012-10-10 Thread Robert Scholte
While improving this, also have a look at https://analysis.apache.org/drilldown/violations/org.apache.maven.shared:maven-shared-aggregator? maven-shared-utils is by far the project with the most violations... Robert Op Mon, 08 Oct 2012 19:19:40 +0200 schreef Olivier Lamy : 2012/10/8 Robert Sc

Re: core-integration-testing-maven-3-jdk-1.7 - Build # 178 - Fixed

2012-10-10 Thread wseth
PLEASE REMOVE ME FROM THIS LIST Apache Jenkins Server wrote: = The Apache Jenkins build system has built core-integration-testing-maven-3-jdk-1.7 (build #178) Status: Fixed Check console output at https://builds.apache.org/job/core-integration-testing-maven-3-jdk-1.7/178/

Re: Flipping Maven Core to Git

2012-10-10 Thread Anders Hammar
I like the sound of 3.1:-) /Anders On Wed, Oct 10, 2012 at 8:36 PM, Kristian Rosenvold wrote: > It's just two simple projects that have some very simple fixes that > need to be done (git does not preserve empty directories and I seem to > recall that a couple of it's failed due to this). > >

Re: Flipping Maven Core to Git

2012-10-10 Thread Kristian Rosenvold
It's just two simple projects that have some very simple fixes that need to be done (git does not preserve empty directories and I seem to recall that a couple of it's failed due to this). I say we do the 3.1 release off git ;) Move both. Kristian 2012/10/10 Anders Hammar : > I see no reason th

Re: Flipping Maven Core to Git

2012-10-10 Thread Anders Hammar
I see no reason they need to be migrate at the same time. /Anders On Wed, Oct 10, 2012 at 7:53 PM, Jason van Zyl wrote: > So in chatting with Kristian it appears the the core is ready to flip, while > the integration tests need some work. Can we flip the core and work on the > core integration

Flipping Maven Core to Git

2012-10-10 Thread Jason van Zyl
So in chatting with Kristian it appears the the core is ready to flip, while the integration tests need some work. Can we flip the core and work on the core integrations test afterward? Thanks, Jason -- Jason van Zyl Founder & CTO, Sonaty

Re: Converting Maven Core to Git

2012-10-10 Thread Jason van Zyl
So what exactly is left to be done and can they be done now. I'm trying to finish my work and I would just not do this with subversion at all. On Oct 10, 2012, at 12:43 PM, Kristian Rosenvold wrote: > The repo is already ported, it's just a matter having infra flip some > switches. ISTR there

Re: Converting Maven Core to Git

2012-10-10 Thread Kristian Rosenvold
The repo is already ported, it's just a matter having infra flip some switches. ISTR there are some issues that need to be fixed in the core it's when running from a git repo Those issues can be fixed now ;) Kristian Den 10. okt. 2012 kl. 18:28 skrev Jason van Zyl : > Hi, > > Where are the scri

Converting Maven Core to Git

2012-10-10 Thread Jason van Zyl
Hi, Where are the scripts that were used to convert the other repos to Git? I'm going to spend tomorrow trying to convert Maven core over to Git as trying to finish the other work I'm trying to do and using Subversion is getting in my way so I'd just like to be done with moving the core over to

Re: SLF4J integration

2012-10-10 Thread ceki
On 10.10.2012 15:42, Mark Struberg wrote: Hi Mark, > Hi! > Here are a few basic observations about slf4j. slf4j really rocks for > end user applications, but when it comes to deep container core stuff > you must take care about classloader clashes much more than within an > end-user project. W

Re: SLF4J integration

2012-10-10 Thread Stephen Connolly
On 10 October 2012 14:42, Mark Struberg wrote: > Hi! > > Here are a few basic observations about slf4j. > slf4j really rocks for end user applications, but when it comes to deep > container core stuff you must take care about classloader clashes much more > than within an end-user project. We jus

Re: SLF4J integration

2012-10-10 Thread Mark Struberg
Hi! Here are a few basic observations about slf4j. slf4j really rocks for end user applications, but when it comes to deep container core stuff you must take care about classloader clashes much more than within an end-user project. We just don't know what a user defined in his sections… If we

Re: [VOTE] Apache Maven Sources plugin 2.2.1

2012-10-10 Thread Hervé BOUTEMY
+1 Regards, Hervé Le mardi 9 octobre 2012 13:02:51 Olivier Lamy a écrit : > Hi, > I'd like to release Maven Sources Plugin 2.2.1. > We fix 1 blocking issue which prevent some users to upgrade: > http://jira.codehaus.org/browse/MSOURCES-62 > > Staging repository: > https://repository.apache.org/

Re: [VOTE] Apache Maven Sources plugin 2.2.1

2012-10-10 Thread Baptiste MATHUS
+1 (non binding). Just tested it on our main multimodule project. Cheers 2012/10/10 Tony Chemit > On Tue, 9 Oct 2012 13:02:51 +0200 > Olivier Lamy wrote: > > +1, (non-binding) > > still wroks fine on my projects. > > thanks, > > tony. > > > Hi, > > I'd like to release Maven Sources Plugin 2.2

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Luca Tagliani
It works! Thanks for the support. BR Luca -- View this message in context: http://maven.40175.n5.nabble.com/Submit-patch-to-maven-changes-plugin-tp5723771p5725477.html Sent from the Maven Developers mailing list archive at Nabble.com.

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Stephen Connolly
If it works the way I suspect it works, login as your existing user, change the email address. http://xircles.codehaus.org/my/email/addresses will let you add a throw-away address (a good one is if using google apps email to add +throwaway before the @) and then remove the one that is blocking yo

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Luca Tagliani
Stephan, thanks for the information, but I cannot re-signup, because the system say that the mail is used yet... obviously. How can I delete my old account to recreate a new one? BR Luca -- View this message in context: http://maven.40175.n5.nabble.com/Submit-patch-to-maven-changes-plugin-

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Stephen Connolly
I think the issue is that you used a . in your xircles username luca.tagliani Try signing up again with a alpha-num only xircles username and hopefully that will sync to JIRA directly I cannot grab Ben on IRC at the moment (most likely he is eating dinner... upside down - nevermind he thinks it'

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Luca Tagliani
I just create the xircles account. So what I have to do to have a Jira account? BR Luca -- View this message in context: http://maven.40175.n5.nabble.com/Submit-patch-to-maven-changes-plugin-tp5723771p5725455.html Sent from the Maven Developers mailing list archive at Nabble.com. --

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Anders Hammar
It looks like you don't create account in JIRA any longer, but it is driven from Xircles. /Anders On Wed, Oct 10, 2012 at 10:25 AM, Luca Tagliani wrote: > But I can't see a way to create a Jira account... > > Not from xircles neither from Jira itself > > BR > > Luca > > > > -- > View this messag

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Luca Tagliani
But I can't see a way to create a Jira account... Not from xircles neither from Jira itself BR Luca -- View this message in context: http://maven.40175.n5.nabble.com/Submit-patch-to-maven-changes-plugin-tp5723771p5725446.html Sent from the Maven Developers mailing list archive at Nabble.com.

Re: [VOTE] Apache Maven Sources plugin 2.2.1

2012-10-10 Thread Tony Chemit
On Tue, 9 Oct 2012 13:02:51 +0200 Olivier Lamy wrote: +1, (non-binding) still wroks fine on my projects. thanks, tony. > Hi, > I'd like to release Maven Sources Plugin 2.2.1. > We fix 1 blocking issue which prevent some users to upgrade: > http://jira.codehaus.org/browse/MSOURCES-62 > > Stag

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Stephen Connolly
you create the jira account and then associate that with your xircles yes I know! if it helps scream "Ben!" On 10 October 2012 08:58, Luca Tagliani wrote: > Hi Olivier, > I have just created an account on xircles a few days ago, but I cannot > login to jira. > I specified a jira username i

Re: Submit patch to maven-changes-plugin

2012-10-10 Thread Luca Tagliani
Hi Olivier, I have just created an account on xircles a few days ago, but I cannot login to jira. I specified a jira username in the xircles profile, but when I try to login to Jira the system say that the username doesn't exists... BR Luca -- View this message in context: http://maven.401

Re: [VOTE] Apache Maven Sources plugin 2.2.1

2012-10-10 Thread Anders Hammar
+1 The correct url for the staged site is: http://maven.apache.org/plugins/maven-source-plugin-2.2.1/ I found a few non-working links in the site. I've filed MSOURCES-63 for that and will take care of them for the next release. /Anders On Wed, Oct 10, 2012 at 7:32 AM, Stephane Nicoll wrote: >