Maven project

2011-02-01 Thread Jonthan DeMaagd
Maven 3.0.2 was installed correctly on Windows Vista. Check for correct installation of maven results: mvn -v Apache Maven 3.0.2 (r1056850; 2011-01-08 19:58:10-0500) Java version: 1.6.0_23, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_23\jre Default locale:

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread Kalyan Akella
Hi, Thank you for the patch review comments. I hope it is integrated to the trunk. My next steps: 1. Implement support for skipping multiple plugins/executions at the CLI. 2. Implement ability to skip plugin execution through the POM as required by http://jira.codehaus.org/browse/MNG-3102 3. Add

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread Kristian Rosenvold
Our main topic of discussion on irc was initially if this *should* be a 3.0.X or 3.1 issue due to being somewhat of a borderline between improvement/new feature. It seems to me like the way this discussion is heading, it should probably be tagged 3.1. I agree very much about getting some well defi

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread Jason van Zyl
So the technical work was done implementing this but no where in the issue does it describe why this feature is useful. This fundamentally changes the behaviour of the lifecycle and the example listed in the issue is skipping tests. Some explanation of why this is good would be nice, there's no

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread Kristian Rosenvold
Given that we're talking about just 2-3(?) options after all these years I am not going to loose any sleep in fear of combinatorial explosion. >But in any case, we should allow the user to avoid using CLI options at > all if he doesn't want to. Which can be done with the use of properties and the

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread John Casey
On 2/1/11 3:14 PM, Kristian Rosenvold wrote: Technically, if we have a bag of known loopholes that can be harmful in release I'd think the release plugin should verify that these aren't present. I'd tend to agree, though to be pedantic, it's possible the release plugin would have to grow to

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread John Casey
My understanding of the way the release plugin currently works, is that it reproduces the original input CLI options to the forked execution...such that if you use: mvn -Papache-release release:perform while at the same time configuring a releaseProfile of apache-release, it'll fork something

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread Kristian Rosenvold
Technically, if we have a bag of known loopholes that can be harmful in release I'd think the release plugin should verify that these aren't present. Kristian ti., 01.02.2011 kl. 15.07 -0500, skrev John Casey: > FWIW, I'd really love to see us limit the use of command-line parameters > that

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread Stephen Connolly
Yeah but as release:perform forks a build the cli arguments would be ignored... or have I missed something in the specifics of this patch On 1 February 2011 20:07, John Casey wrote: > FWIW, I'd really love to see us limit the use of command-line parameters > that change the way the build runs. I

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread John Casey
FWIW, I'd really love to see us limit the use of command-line parameters that change the way the build runs. I understand this can be very useful during debugging (if you're not able run a particular single test in an IDE for some reason, as one example), but the danger represented by specifyin

Re: Regarding MNG-3321 - Support for Skipping Plugin Execution

2011-02-01 Thread Kristian Rosenvold
I have looked at the patch diffs and it looks really great, one of the better patches I've seen in the issue trackers ! We had a quick chat about this patch on irc and we figured we could take this patch for 3.0.x. One thing we would like though, is to be able to specify multiple exclusions, not