Re: Cleanup to SNAPSHOT version handling

2010-12-29 Thread Brian Fox
--mobile On Dec 28, 2010, at 6:50 PM, Jason van Zyl wrote: > > On Dec 28, 2010, at 6:06 PM, Benjamin Bentmann wrote: > >> Brian E. Fox wrote: >> >>> -1 to a, +1 to b >> >> Just to be clear, I meant a) AND b), not either or. a) is concerned about >> the actual version interpretation, b) about gu

Re: Surefire/Failsafe plugin code duplication

2010-12-29 Thread Brett Porter
On 29/12/2010, at 10:49 PM, Kristian Rosenvold wrote: >> Why don't we just fix maven-plugin-plugin, or switch to annotations... >> Anything else is just a stop gap > > Hmm. Yes. Is there an issue for this and/or some good reason why this > hasn't been done ? > > I also see that the significant

Re: Surefire/Failsafe plugin code duplication

2010-12-29 Thread Kristian Rosenvold
> Why don't we just fix maven-plugin-plugin, or switch to annotations... > Anything else is just a stop gap Hmm. Yes. Is there an issue for this and/or some good reason why this hasn't been done ? I also see that the significant bit (extracting documentation/attributes to base class), actually i

Re: Surefire/Failsafe plugin code duplication

2010-12-29 Thread Stephen Connolly
Why don't we just fix maven-plugin-plugin, or switch to annotations... Anything else is just a stop gap - Stephen --- Sent from my Android phone, so random spelling mistakes, random nonsense words and other nonsense are a direct result of using swype to type on the screen On 29 Dec 2010 10:51, "K

Surefire/Failsafe plugin code duplication

2010-12-29 Thread Kristian Rosenvold
The surefire/failsafe plugins share a common module "surefire-common", with an AbstractSurefireMojo and an interface that the specific implementations need to implement (Surefire/Failsafe). We had this discussion earlier, and because the mojo annotations have to be in the same jar file as the plug