Re: AbstractMojo.getLog vs LogEnabled.enableLogging (found in maven-eclipse-plugin)

2009-03-27 Thread Jason van Zyl
On 27-Mar-09, at 2:10 PM, Barrie Treloar wrote: On Sat, Mar 28, 2009 at 1:59 AM, Jason van Zyl wrote: On 26-Mar-09, at 5:29 PM, Barrie Treloar wrote: EclipsePlugin extends AbstractIdeSupportMojo AbstractIdeSupportMojo extends AbstractMojo implements LogEnabled AbstractMojo has getLog() Log

Re: AbstractMojo.getLog vs LogEnabled.enableLogging (found in maven-eclipse-plugin)

2009-03-27 Thread Barrie Treloar
On Sat, Mar 28, 2009 at 1:59 AM, Jason van Zyl wrote: > > On 26-Mar-09, at 5:29 PM, Barrie Treloar wrote: > >> EclipsePlugin extends AbstractIdeSupportMojo >> AbstractIdeSupportMojo extends AbstractMojo implements LogEnabled >> AbstractMojo has getLog() >> LogEnabled has enableLogging() >> >> Whic

Re: Recording build environment

2009-03-27 Thread Jason van Zyl
On 27-Mar-09, at 9:07 AM, Paul Gier wrote: Jason van Zyl wrote: On 27-Mar-09, at 7:09 AM, Nord, James wrote: What would be the solution for Maven 3? I currently have a plug-in that does exactly what you describe. It wouldn't change, a plugin is the way to go if you want to collect inform

Re: Recording build environment

2009-03-27 Thread Paul Gier
Jason van Zyl wrote: On 27-Mar-09, at 7:09 AM, Nord, James wrote: What would be the solution for Maven 3? I currently have a plug-in that does exactly what you describe. It wouldn't change, a plugin is the way to go if you want to collect information which currently is an arbitrary set of

Re: MNG-3038

2009-03-27 Thread Patrick Schneider
Okay, cool. Like I said... it's been awhile :) Anyway, I'll start working on this today and be in touch. On Fri, Mar 27, 2009 at 10:15 AM, John Casey wrote: > Looks like another victim of the version shift. The "2.1" referred to in > that comment is what we're now referring to as "3.0.x"...a

Re: Recording build environment

2009-03-27 Thread Jason van Zyl
On 27-Mar-09, at 7:09 AM, Nord, James wrote: What would be the solution for Maven 3? I currently have a plug-in that does exactly what you describe. It wouldn't change, a plugin is the way to go if you want to collect information which currently is an arbitrary set of information. /**

Re: Recording build environment

2009-03-27 Thread Jason van Zyl
There's an example somewhere that John made which records whatever you want and attaches that information as part of the deploy. On 27-Mar-09, at 7:04 AM, Paul Gier wrote: It seems reasonable to me to have a property that contains this information, so I created MNG-4112. The property could

Re: AbstractMojo.getLog vs LogEnabled.enableLogging (found in maven-eclipse-plugin)

2009-03-27 Thread Jason van Zyl
On 26-Mar-09, at 5:29 PM, Barrie Treloar wrote: EclipsePlugin extends AbstractIdeSupportMojo AbstractIdeSupportMojo extends AbstractMojo implements LogEnabled AbstractMojo has getLog() LogEnabled has enableLogging() Which logger should be used? getLog() from AbstractMojo or Use the getLog()

Re: MNG-3038

2009-03-27 Thread John Casey
Looks like another victim of the version shift. The "2.1" referred to in that comment is what we're now referring to as "3.0.x"...aside from that, I'm not entirely sure why Joakim said it wasn't fixable until that release. -john Patrick Schneider wrote: Hi All, It's been awhile since I've h

Re: pom properties for m2eclipse

2009-03-27 Thread nicolas de loof
Nice to know.Sory for the noise on d...@maven list :) On Fri, Mar 27, 2009 at 3:52 PM, Igor Fedorenko wrote: > We are adding something like this to 0.9.8. I can provide more details if > you are interested, but m2e dev list is probably a better place for this > discussion. > > -- > Regards, > Ig

Re: pom properties for m2eclipse

2009-03-27 Thread Igor Fedorenko
We are adding something like this to 0.9.8. I can provide more details if you are interested, but m2e dev list is probably a better place for this discussion. -- Regards, Igor nicolas de loof wrote: Hi I wonder if there is any way to "configure" m2eclipse settings using dedicated meta-datas

Re: Recording build environment

2009-03-27 Thread Paul Gier
Thanks for the code! Maybe this goal could be added to something like the buildnumber-maven-plugin? Nord, James wrote: What would be the solution for Maven 3? I currently have a plug-in that does exactly what you describe. /** * Goal which stores the maven core version in a property maven.ve

RE: Recording build environment

2009-03-27 Thread Nord, James
What would be the solution for Maven 3? I currently have a plug-in that does exactly what you describe. /** * Goal which stores the maven core version in a property maven.version. * * @goal getVersion * @phase validate * @author James Nord */ public class MavenVersionMojo extends AbstractMo

Re: Recording build environment

2009-03-27 Thread Paul Gier
It seems reasonable to me to have a property that contains this information, so I created MNG-4112. The property could probably also be used to resolve MSHARED-38. Of course the negative part is that the property wouldn't work with earlier versions of maven, but maybe it can start with 3.0.

RE: Re : Re : [VOTE] Release Maven eclipse plugin version 2.6

2009-03-27 Thread Brian E. Fox
Ok I just wasn't sure because there was lots of talk about eclipse plugin fixes in parallel so I lost track. -Original Message- From: Barrie Treloar [mailto:baerr...@gmail.com] Sent: Friday, March 27, 2009 2:52 AM To: Maven Developers List Subject: Re: Re : Re : [VOTE] Release Maven eclip

Re: Re : Re : [VOTE] Release Maven eclipse plugin version 2.6

2009-03-27 Thread Olivier Lamy
+1 -- Olivier 2009/3/27 Barrie Treloar : > On Fri, Mar 27, 2009 at 1:15 PM, Brian E. Fox > wrote: >> Has this vote been officially cancelled? > > No, why? > > There is definitely a defect introduced with setting inclusions to > **/*.java (MECLIPSE-443 added inclusions) for Apsect developers (see

[RESULT] [VOTE] Release Maven Release plugin version 2.0-beta-9 and scm 1.2

2009-03-27 Thread Olivier Lamy
Hi, The votes has passed with the following result : +1 (binding) : Arnaud HERITIER, Jason van Zyl,Emmanuel Venisse, Olivier Lamy +1 (non-binding) : Marc Struberg I will move artifacts to central repo and publish the site. Thanks, -- Olivier

Re: Re : Re : [VOTE] Release Maven eclipse plugin version 2.6

2009-03-27 Thread Arnaud HERITIER
If I do +3 ?? :-) On Fri, Mar 27, 2009 at 7:51 AM, Barrie Treloar wrote: > On Fri, Mar 27, 2009 at 4:48 PM, Arnaud HERITIER > wrote: > > No, there's no reason to stop it.We'll publish a 1.6.1 in few days if > > necessary > > Except the current vote count :) > > +1 (binding): > aherit...@gmail.

Re: [VOTE] Release Maven Scm 1.2 and maven-release-plugin 2.0-beta-9

2009-03-27 Thread Olivier Lamy
So my +1 means 2 * +1 :-). -- Olivier 2009/3/23 Olivier Lamy : > Hi, > I'd like to release maven-scm 1.2 and maven-release-plugin 2.0-beta-9. > This two release are in only one vote because they are very dependant > due to a fix for people using subversion version > 1.5.0. > > Concerning maven-sc