Re: svn commit: r668853

2008-06-25 Thread Brett Porter
Hi Shane, A few quick comments on this... Can you make sure there are license headers? On 18/06/2008, at 6:10 AM, [EMAIL PROTECTED] wrote: Added: maven/sandbox/trunk/maven/maven-project-builder/maven-project- builder.iml I think we generally don't check these in. + +n

Re: svn commit: r671647

2008-06-25 Thread Brett Porter
Hi John, Couple of questions: On 26/06/2008, at 4:28 AM, [EMAIL PROTECTED] wrote: -pathTranslator.alignToBaseDirectory( model, basedir ); +if ( basedir != null ) +{ +pathTranslator.alignToBaseDirectory( model, basedir ); +} Under what conditions i

Re: [VOTE][RESULT] Release Maven Plugin Tools version 2.4.2

2008-06-25 Thread Dennis Lundberg
The vote has passed with the following votes: +1: Vincent Siveton, Joakim Erdfelt, Olivier Lamy, Dennis Lundberg I'll move the artifacts over to the repository. Dennis Lundberg wrote: Hi, We solved 19 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11139&styleName=Html&vers

Re: [VOTE][RESULT] Release Maven Repository Plugin version 2.1

2008-06-25 Thread Dennis Lundberg
The vote has passed with the following votes: +1: Vincent Siveton, Olivier Lamy, Dennis Lundberg I'll move the artifacts over to central. Dennis Lundberg wrote: Hi, We solved 5 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11250&styleName=Html&version=12548 There are

Re: [VOTE] Release Maven Plugin Tools version 2.4.2

2008-06-25 Thread Dennis Lundberg
+1 from me Dennis Lundberg wrote: Hi, We solved 19 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11139&styleName=Html&version=14166 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11139&status=1 St

Re: [VOTE] Release Maven Repository Plugin version 2.1

2008-06-25 Thread Dennis Lundberg
+1 from me :-) Dennis Lundberg wrote: Hi, We solved 5 issues: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=11250&styleName=Html&version=12548 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&pid=11250&status=1

Re: [Proposal] Pom Code Style (WAS svn commit: r670264 - /maven/plugins/trunk/maven-site-plugin/pom.xml)

2008-06-25 Thread Benjamin Bentmann
Jesse McConnell wrote: pom:reformat would be pretty nice +1, cool idea. Might we worth to distinguish the use cases "reorder" and "reformat", i.e. separate indentation stuff from element ordering. BTW, Paul had once started a Pom Plugin [0], maybe there is something to reuse/merge. Benj

Re: [DISCUSS] An inherited "Maven Projects" menu for on all our sites

2008-06-25 Thread Jesse McConnell
I agree with vincent and this is a great improvement nice! jesse On Wed, Jun 25, 2008 at 10:22 AM, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > Benjamin Bentmann wrote: >> >> Dennis Lundberg schrieb: >> >>> I want to separate "Maven Projects", as they are called in the menu of >>> the main site,

Re: [Proposal] Pom Code Style (WAS svn commit: r670264 - /maven/plugins/trunk/maven-site-plugin/pom.xml)

2008-06-25 Thread Jesse McConnell
+1, great idea Not sure it was mentioned before or not but would also be nice to have something like help:reformat goal for juggling things around in the pom to the correct format. Maybe it would be more appropriate to clean up and finish off some of the things I had worked on with the pom plugin

Re: [DISCUSS] An inherited "Maven Projects" menu for on all our sites

2008-06-25 Thread Dennis Lundberg
Benjamin Bentmann wrote: Dennis Lundberg schrieb: I want to separate "Maven Projects", as they are called in the menu of the main site, from breadcrumbs that tells you where on the site you currently are. +1, moving the "Maven Projects" out of the breadcrumbs scales better with increasing p

Re: [Proposal] Pom Code Style (WAS svn commit: r670264 - /maven/plugins/trunk/maven-site-plugin/pom.xml)

2008-06-25 Thread Dennis Lundberg
Benjamin Bentmann wrote: Vincent Siveton schrieb: I propose to improve [1] to add a code style for our pom files. +1 for some convention (which is documented as such). Yep, +1 for a POM code style I see the following in this order. Considering other POMs like parent POMs and Mojo, your