Possible bug activating external profiles?

2008-04-06 Thread Abel Muiño
External profiles defined with true are always activated even when explicitly requested to by deactivated (by including them in the MavenRequest.addInactiveProfiles(). I've seen this while embedding maven in Eclipse. Looking at the code, it seems like that was not the intention (looks like an unp

Re: Common Bugs

2008-04-06 Thread Barrie Treloar
On Mon, Apr 7, 2008 at 6:21 AM, Brett Porter <[EMAIL PROTECTED]> wrote: > Hey Benjamin, > > I wonder if it's worth posting these as a series under the developers > section of the Maven site? And building custom Checsktyle/PMD rules (if built in ones dont exist) to flag these as error? --

Re: [VOTE] POM Element for Source File Encoding

2008-04-06 Thread Paul Benedict
+1 .. I'd like to know if this could also be achieved via toolchains. Hervé BOUTEMY wrote: > > > > > Hi, > > > > > > Since the discussion on the list about Maven and encoding 2 weeks ago, > > > Benjamin and I worked on a proposal to have: > > > 1. a central point of configuration of sources encodi

Re: [VOTE] POM Element for Source File Encoding

2008-04-06 Thread Paul Benedict
Please clarify the proposal. When you say "source" files, you mean things like Java files not POM files? Paul On Sun, Apr 6, 2008 at 2:56 PM, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > +1 > > Hervé BOUTEMY wrote: > > > Hi, > > > > Since the discussion on the list about Maven and encoding 2 wee

Re: Common Bugs

2008-04-06 Thread Brett Porter
Hey Benjamin, I wonder if it's worth posting these as a series under the developers section of the Maven site? - Brett On 06/04/2008, at 9:46 PM, Benjamin Bentmann wrote: new File( new URI( url.toString() ) ) Correction: JRE 1.4 is happily returning invalid/unescaped URLs from ClassLoa

Re: [VOTE] POM Element for Source File Encoding

2008-04-06 Thread Dennis Lundberg
+1 Hervé BOUTEMY wrote: Hi, Since the discussion on the list about Maven and encoding 2 weeks ago, Benjamin and I worked on a proposal to have: 1. a central point of configuration of sources encoding, to be used by each and every plugin, 2. a default value set to ISO-8859-1 (instead of platfo

Re: [proposal] AbstractMojo enhancement

2008-04-06 Thread Mark Hobson
+1, I've thought this numerous times in the past. This class may be handy for the new component: http://svn.codehaus.org/mojo/trunk/sandbox/apt-maven-plugin/src/main/java/org/codehaus/mojo/apt/LogUtils.java Mark On 05/04/2008, Jason van Zyl <[EMAIL PROTECTED]> wrote: > > On 5-Apr-08, at 12:21

Re: Common Bugs

2008-04-06 Thread Benjamin Bentmann
new File( new URI( url.toString() ) ) Correction: JRE 1.4 is happily returning invalid/unescaped URLs from ClassLoader.getResource(), making the above suggestion fail with a URISyntaxException. The new suggestion is to use FileUtils.toFile(URL) [0] from Commons IO. A similar methods exists

Re: Common Bugs

2008-04-06 Thread Benjamin Bentmann
Hi, 6) URLs and Filesystem Paths URLs and filesystem paths are really two different beasts and converting between them is not trivial. The main source of problems is that different encoding rules apply for the strings that make up a URL or filesystem path. For example, consider the following