Re: More on plugin integration testing

2007-12-27 Thread Brett Porter
On 27/12/2007, at 4:15 PM, Dan Fabulich wrote: 1) This document draws a distinction between "integration testing" and "functional testing." The two terms are defined, but I don't think I quite understand the distinction in practice. In particular, this doc states that only two of the avai

[jira] Subscription: Design & Best Practices

2007-12-27 Thread jira
Issue Subscription Filter: Design & Best Practices (29 issues) Subscriber: mavendevlist Key Summary MNG-2184Possible problem with @aggregator and forked lifecycles http://jira.codehaus.org/browse/MNG-2184 MNG-612 implement conflict resolution techniques htt

Re: Reading another plugins configuration: there's a patch available that does this

2007-12-27 Thread Jason van Zyl
On 27 Dec 07, at 4:02 PM 27 Dec 07, Dennis Lundberg wrote: Hi I've been applying patches to the pmd-plugin from Xavier Le Vourch. The patches have been of good quality. Now I'm looking at a patch for http://jira.codehaus.org/browse/MPMD-63 which reads the jdk source level from the compiler

Re: Reading another plugins configuration: there's a patch available that does this

2007-12-27 Thread Brett Porter
That's the current "standard practice" I think (doesn't the IDEA plugin already do it? That would be a good place to copy behaviour from for consistency). Toolchains should make it all go away eventually... - Brett On 28/12/2007, at 11:02 AM, Dennis Lundberg wrote: Hi I've been applying

Reading another plugins configuration: there's a patch available that does this

2007-12-27 Thread Dennis Lundberg
Hi I've been applying patches to the pmd-plugin from Xavier Le Vourch. The patches have been of good quality. Now I'm looking at a patch for http://jira.codehaus.org/browse/MPMD-63 which reads the jdk source level from the compiler-plugin, so that it can feed this info to PMD. This topic has been

Re: how is java.home determined?

2007-12-27 Thread Evan Worley
I moved our thread onto the Tobago mailing list, let's see if I can get a bite. If not I'll try to look into adding some support myself. Thanks for your help, Evan On Dec 27, 2007 2:40 PM, Brett Porter <[EMAIL PROTECTED]> wrote: > https://svn.codehaus.org/mojo/trunk/sandbox/apt-maven-plugin/ >

Re: how is java.home determined?

2007-12-27 Thread Brett Porter
https://svn.codehaus.org/mojo/trunk/sandbox/apt-maven-plugin/ No idea what it is like though. Certainly would need some help to get it into a release state regardless. On 28/12/2007, at 9:21 AM, Evan Worley wrote: I have not seen other APT plugin implementations. I agree with you that the

Re: how is java.home determined?

2007-12-27 Thread Evan Worley
I have not seen other APT plugin implementations. I agree with you that the apt-plugin should be handling this problem. I will try to get in touch with the tobago people. Thanks, Evan On Dec 27, 2007 2:13 PM, Brett Porter <[EMAIL PROTECTED]> wrote: > I think you can use ${java.home}/../lib/too

Re: how is java.home determined?

2007-12-27 Thread Brett Porter
I think you can use ${java.home}/../lib/tools.jar (and remember to omit it on non-Sun JVM platforms), and document that the user must be running Java from the JDK, not a JRE (and present a helpful error message if the class you are looking for cannot be found). You might look at the source

Re: how is java.home determined?

2007-12-27 Thread Evan Worley
Thanks for the info Brett, I am loading it via a dependency. I depend on the maven-apt-plugin ( http://myfaces.apache.org/tobago/tobago-tool/maven-apt-plugin/) which has a system scoped dependency on tools.jar So if we can't ensure that java.home is set to a JDK, how can we recommend people use

Re: dependency on archiva-configuration -> archiva-model in r602916 for legacy paths

2007-12-27 Thread Brett Porter
On 28/12/2007, at 5:05 AM, nicolas de loof wrote: Just wanted to have LegacyArtifactPath hide the String representation used in storage, but project dependencies is also valuable. Your reasoning makes sense :) Why shouldn't archiva-configuration depend on achiva-model ? IMHO, the "model

Re: how is java.home determined?

2007-12-27 Thread Brett Porter
It's set by the JVM itself - you will probably need profiles for the different possibilities (like the Mac one, where there is no tools.jar). Are you loading this via a dependency, or creating your own classloader? - Brett On 28/12/2007, at 5:24 AM, Evan Worley wrote: Hi All, I need to hav

RE: what's up with "artifactHandler.isAddedToClasspath()" ?

2007-12-27 Thread Brian E. Fox
Hrm missed that, but it confirms that something is wrong because it is correctly set to true. Guess I'll keep digging... -Original Message- From: Tom Huybrechts [mailto:[EMAIL PROTECTED] Sent: Thursday, December 27, 2007 3:35 PM To: Maven Developers List Subject: Re: what's up with "artif

Re: what's up with "artifactHandler.isAddedToClasspath()" ?

2007-12-27 Thread Tom Huybrechts
It's set in the ArtifactHandler configuration in components.xml. On Dec 27, 2007 9:12 PM, Brian E. Fox <[EMAIL PROTECTED]> wrote: > I'm debugging a problem that happens in both 2.0.8/9-SNAPSHOT and > 2.1-SNAPSHOT...that is project.getRunTimeArtifacts returns an empty list > even when it clearly

what's up with "artifactHandler.isAddedToClasspath()" ?

2007-12-27 Thread Brian E. Fox
I'm debugging a problem that happens in both 2.0.8/9-SNAPSHOT and 2.1-SNAPSHOT...that is project.getRunTimeArtifacts returns an empty list even when it clearly should not. I debug into the project and I see that all the getXXXArtifacts make a call like this: if ( a.getArtifactHandler().isAdde

how is java.home determined?

2007-12-27 Thread Evan Worley
Hi All, I need to have the JDK's tools.jar on my classpath and have been fumbling through the configuration to make this happen. I found the following page which describes how to use the java.home property to locate the tools.jar, http://maven.apache.org/general.html#tools-jar-dependency. But I

Re: dependency on archiva-configuration -> archiva-model in r602916 for legacy paths

2007-12-27 Thread nicolas de loof
Just wanted to have LegacyArtifactPath hide the String representation used in storage, but project dependencies is also valuable. Why shouldn't archiva-configuration depend on achiva-model ? IMHO, the "model" should have no dependency. But you can make any change required for better architecture.

Re: [VOTE] [Take 2] Release Maven Surefire version 2.4

2007-12-27 Thread Marat Radchenko
A big +1 because of testng support. 2007/12/27, Dan Fabulich <[EMAIL PROTECTED]>: > > Hi, > > Maven Surefire version 2.4 is back on the runway. A handful of bugs were > fixed since the previous take, including SUREFIRE-416 (which blocked the > release). > > Note that I'm still unable to reproduce