[log4j] Links to issues in VOTE emails and release notes (Was: [VOTE] Release Apache Log4j `2.25.1` (RC1))

2025-07-08 Thread Volkan Yazıcı
I see that the most recent VOTE email misses ticket IDs, making it cumbersome to access associated PRs. I can see the Discussion linked, but that is not what I am asking for. Can we share the Issue/PR IDs in the VOTE emails, please? On Sat, Jul 5, 2025 at 11:08 PM Piotr P. Karwasz wrote: > This

[DISCUSSION][VOTE] Release Apache Log4j `2.25.1` (RC1)

2025-07-08 Thread Piotr P. Karwasz
Hi Matt, On 7.07.2025 22:34, Matt Sicker wrote: > Something is buggy for me in the Maven wrapper script which causes this error > to print out: > > mvnw: line 114: mvnw/.mvn/wrapper/maven-wrapper.properties: Not a directory > cannot read distributionUrl property in > mvnw/.mvn/wrapper/maven-wra

Re: [VOTE] Release Apache Log4j `2.25.1` (RC1)

2025-07-08 Thread Volkan Yazıcı
+1 ✅ Signatures ✅ Checksums ✅ `./mvnw verify` *Build platform:* - Xubuntu 24.04.2 - OpenJDK 17.0.15+6-Ubuntu-0ubuntu124.04 - x86_64 *Notes:* I had the same issues reported by Matt. `mvnw` needed an `chmod u+x mvnw` amendment. This is a known issue, I reported it to Maven[1][2], Piotr provided

Release notes, changelog and commits

2025-07-08 Thread Piotr P. Karwasz
Hi Volkan, On 8.07.2025 10:44, Volkan Yazıcı wrote: > I see that the most recent VOTE email misses ticket IDs, making it > cumbersome to access associated PRs. I can see the Discussion linked, but > that is not what I am asking for. > > Can we share the Issue/PR IDs in the VOTE emails, please? I

[DISCUSSION][VOTE] Release Apache Log4j `2.25.1` (RC1)

2025-07-08 Thread Piotr P. Karwasz
Hi Volkan, On 8.07.2025 09:29, Volkan Yazıcı wrote: > I could not resolve the `artifact:compare` failure on > `log4j-parent`. This is an important problem, but not > a release blocker, AFAICT. Just to clarify—are you referring to the reproducibility issue in `log4j-bom`, or is this a separate pro

Re: [DISCUSSION][VOTE] Release Apache Log4j `2.25.1` (RC1)

2025-07-08 Thread Matt Sicker
The diffoscope output for the module file is simple: diffoscope log4j-api/target/reference/org.apache.logging.log4j/log4j-api-2.25.1.module log4j-api/target/publications/maven/module.json --- log4j-api/target/reference/org.apache.logging.log4j/log4j-api-2.25.1.module +++ log4j-api/target/publica

Re: [DISCUSSION][VOTE] Release Apache Log4j `2.25.1` (RC1)

2025-07-08 Thread Piotr P. Karwasz
Hi Matt, On 8.07.2025 18:34, Matt Sicker wrote: > The diffoscope output for the module file is simple: > > [...] > │ "createdBy": { > │ "maven": { > │ -"version": "3.9.8" > │ +"version": "3.9.10" > │ } I didn't know about this aspect of the Gradle Mo

Re: [DISCUSSION][VOTE] Release Apache Log4j `2.25.1` (RC1)

2025-07-08 Thread Matt Sicker
https://gist.github.com/jvz/54c8222bd8ef3dabd690994ab35d85d2 gist:54c8222bd8ef3dabd690994ab35d85d2 gist.github.com Logs say the diff is mainly due to compression levels. > On Jul 8, 2025, at 13:38, Piotr P. Karwasz wrote: > > Hi Matt, > > On 8.07.2025 18:34, Matt Sicker wrote: >> The diffosc