Trying again but not on macOS...
IMO, this text should be removed from the review kit:
"# If preferred, augment `mvnw` with `-DskipTests` to speed things up"
You can't possibly validate an RC without running tests: "Look how fast I can
NOT perform due diligence!"
Gary
On 2024/08/31 19:30:00 "P
It's fails differently on Ubuntu:
...
[INFO] --- artifact:3.5.1:compare (default-cli) @ log4j-api ---
[WARNING] property is inherited from outside
the reactor, it should be defined in parent POM from reactor
/mnt/c/Users/ggregory/rc/2.24.0/src/.flattened-pom.xml
[INFO] Reference buildinfo file
Note that I add "clean" *(why does the kit not use "clean"?)
mvnw -Prelease clean verify artifact:compare -Dreference.repo=$NEXUS_REPO
Gary
On 2024/09/03 13:21:32 "Gary D. Gregory" wrote:
> It's fails differently on Ubuntu:
>
> ...
> [INFO] --- artifact:3.5.1:compare (default-cli) @ log4j-api -
Note that I add "clean" *(why does the kit not use "clean"?)
mvnw -Prelease clean verify artifact:compare -Dreference.repo=$NEXUS_REPO
Gary
On 2024/09/03 13:21:32 "Gary D. Gregory" wrote:
> It's fails differently on Ubuntu:
>
> ...
> [INFO] --- artifact:3.5.1:compare (default-cli) @ log4j-api -
-1
On Windows, I deleting my entire .m2/repository folder and then ran
mvnw -Prelease clean verify artifact:compare -Dreference.repo=%NEXUS_REPO%
and got:
[INFO] Minimal buildinfo generated from downloaded artifacts:
C:\Users\ggregory\rc\2.24.0\src\target\reference\log4j-bom-2.24.0.buildinfo
[
Hi all,
On Sat, 31 Aug 2024 at 21:30, Piotr P. Karwasz wrote:
>
> This is a vote to release the Apache Log4j `2.24.0`.
>
> Website: https://logging.staged.apache.org/log4j/2.24.0/index.html
> GitHub: https://github.com/apache/logging-log4j2
> Commit: 08053687456f6be61ee8206da782a3d051928a57
> Dis
Thank you Piotr!
Gary
On Tue, Sep 3, 2024, 11:17 AM Piotr P. Karwasz
wrote:
> Hi all,
>
> On Sat, 31 Aug 2024 at 21:30, Piotr P. Karwasz
> wrote:
> >
> > This is a vote to release the Apache Log4j `2.24.0`.
> >
> > Website: https://logging.staged.apache.org/log4j/2.24.0/index.html
> > GitHub:
Why doesn't the maven build in the review kit (below) invoke clean goal?
Gary
On Tue, Sep 3, 2024, 11:37 AM wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> pkarwasz pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/logging-parent
This is a vote to release the Apache Log4j `2.24.0`.
Website: https://logging.staged.apache.org/log4j/2.24.0/index.html
GitHub: https://github.com/apache/logging-log4j2
Commit: c79ae325f6a21af45526c202f121bfced188613e
Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j/2.24.0/
Nexus
Hi Gary,
On Tue, 3 Sept 2024 at 18:25, Gary Gregory wrote:
>
> Why doesn't the maven build in the review kit (below) invoke clean goal?
>
> > +sh mvnw -Prelease clean verify artifact:compare
> > -Dreference.repo=$NEXUS_REPO
> > +
> > +# Run tests only (Windows)
> > +sh mvnw -Prelease clean verify
I will remove `clean`, since there is nothing to clean.
We shouldn't add unnecessary overhead.
On Tue, Sep 3, 2024 at 7:01 PM Piotr P. Karwasz
wrote:
> Hi Gary,
>
> On Tue, 3 Sept 2024 at 18:25, Gary Gregory wrote:
> >
> > Why doesn't the maven build in the review kit (below) invoke clean goal?
Sorry to be a pain, on Windows, running 'mvn clean verify', I get:
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 11.48 s
<<< FAILURE! -- in org.apache.logging.log4j.core.net.UrlConnectionFactoryTest
[ERROR]
org.apache.logging.log4j.core.net.UrlConnectionFactoryTest.with
Gary, do you know what is the difference between RC1 and RC2? Nothing.
Piotr only kindly added a one-liner condition check to the contending
(FQDN-related) test to make it up to you. That is the only difference –
plus, he updated the review kit (shared in the email) to avoid the
reproducibility che
Hi Volkan,
On Tue, 3 Sept 2024 at 20:54, Volkan Yazıcı wrote:
> My point is, 3 people verified the release and CI runs passed on all 3
> platforms – there is definitely something unexpected in your setup. As you
> know better, issuing an RC is a time and energy consuming task. Besides RM,
> other
Volcan,
Please stop complaining about the hours I've already sunk into validation
on 3 different operating system on two different machines. You're not
helping the cause.
I can't help but notice the irony that one of the failures is in the
"reproducible" part of the build.
>From my point of view
> You're not helping the cause.
I am offering a video call to assist you. What else do you want me to do?
On Tue, Sep 3, 2024 at 9:51 PM Gary Gregory wrote:
> Volcan,
>
> Please stop complaining about the hours I've already sunk into validation
> on 3 different operating system on two differen
Volkan,
I think Gary told you. He has the right to complain and vote on a release as
he feels. Although I believe it is wrong to do so, I could have voted -1 on the
release do to the release notes and web site issues. With 3 +1 votes Piotr
always had the option to go ahead with the release any
? Clean takes a no time. It ensures no junk is lying around.
Ralph
> On Sep 3, 2024, at 10:58 AM, Volkan Yazıcı wrote:
>
> I will remove `clean`, since there is nothing to clean.
> We shouldn't add unnecessary overhead.
>
> On Tue, Sep 3, 2024 at 7:01 PM Piotr P. Karwasz
> wrote:
>
>> Hi Gar
Thanks Piotr. It is good to know this as I often have lots of source code and
build from various things on my computer.
Ralph
> On Sep 3, 2024, at 12:45 PM, Piotr P. Karwasz wrote:
>
> Hi Volkan,
>
> On Tue, 3 Sept 2024 at 20:54, Volkan Yazıcı wrote:
>> My point is, 3 people verified the rel
19 matches
Mail list logo
