Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-17 Thread Piotr P. Karwasz
Hi Ralph, On Tue, 16 Jul 2024 at 15:17, Ralph Goers wrote: > > * we have a `SpringLookup` and a `SpringPropertySource`. > > SpringLookup returns the value of a key. A property source locates a set of > keys. So comparing them is apples to oranges. Or rather - an apple to a > bushel of apples. P

Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-17 Thread Matt Sicker
I’ll note one design constraint behind property sources and lookups. Property sources are defined in the API while lookups are defined in Core. Besides that, property sources are intended for use with configuration (either for components outside the config file or for reuse in a config file) whi

Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-17 Thread Piotr P. Karwasz
Hi Matt, On Wed, 17 Jul 2024 at 19:03, Matt Sicker wrote: > I’ll note one design constraint behind property sources and lookups. Property > sources are defined in the API while lookups are defined in Core. Since Log4j Core 3 has a different properties system, property sources are technically de

Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-17 Thread Ralph Goers
> On Jul 17, 2024, at 3:09 AM, Piotr P. Karwasz wrote: > > Hi Ralph, > > On Tue, 16 Jul 2024 at 15:17, Ralph Goers wrote: >>> * we have a `SpringLookup` and a `SpringPropertySource`. >> >> SpringLookup returns the value of a key. A property source locates a set of >> keys. So comparing the

Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-17 Thread Ralph Goers
> On Jul 17, 2024, at 2:11 PM, Piotr P. Karwasz wrote: > > Hi Matt, > > On Wed, 17 Jul 2024 at 19:03, Matt Sicker wrote: >> I’ll note one design constraint behind property sources and lookups. >> Property sources are defined in the API while lookups are defined in Core. > > Since Log4j Cor