[log4j-kotlin] Next release (`1.3.1`-vs-`1.4.0`)

2023-12-07 Thread Volkan Yazıcı
Raman, Matt, great that you want to release the next version of the Log4j Kotlin! Thanks for your time and effort. I see that you forked the `release/1.3.1` branch from the `rel/1.3.0` tag, though this misses some minor, but important changes (e.g., SBOM & VDR!) from `main`. I suggest we fork fro

[log4j] Is `bnd` a curse or a blessing?

2023-12-07 Thread Volkan Yazıcı
We use `bnd`, in particular, `bnd-maven-plugin` to programmatically declare JPMS/OSGi module exports and service providers. Effectively, it generates `module-info.class`, `META-INF/services`, and (OSGi-related) `MANIFEST.M

Re: [log4j] Is `bnd` a curse or a blessing?

2023-12-07 Thread Gary Gregory
Note that there is also the Maven moditect plugin but I don't know if it deals with OSGi which brings up the issue of how much we should care about OSGi (I don't know). Gary On Thu, Dec 7, 2023, 9:41 AM Volkan Yazıcı wrote: > We use `bnd`, in particular, `bnd-maven-plugin` > < > https://github.

Re: [log4j] Is `bnd` a curse or a blessing?

2023-12-07 Thread Piotr P. Karwasz
Hi Volkan, I have supplied a PR to generate the service descriptors before Unit tests, but keep the module-info.class only in the JAR: https://github.com/apache/logging-parent/pull/75 On Thu, 7 Dec 2023 at 15:41, Volkan Yazıcı wrote: > *Bad: Programmatic configuration is not enough* > > We stil

Re: [log4j] Is `bnd` a curse or a blessing?

2023-12-07 Thread Piotr P. Karwasz
Hi Gary, On Thu, 7 Dec 2023 at 15:46, Gary Gregory wrote: > > Note that there is also the Maven moditect plugin but I don't know if it > deals with OSGi which brings up the issue of how much we should care about > OSGi (I don't know). We can disable JPMS descriptor generation in BND and switch t

Re: [log4j] Is `bnd` a curse or a blessing?

2023-12-07 Thread Volkan Yazıcı
As I stated, I like `bnd` and am glad to see that its 7.x version will help us lose some extra weight. And indeed we can fix some shortcomings I have mentioned. Though my points still stand: 1. We need extensive tweaking 2. It doesn't always blend well (IDEs, `spring-boot:repackage`, etc.)

Re: [log4j] Is `bnd` a curse or a blessing?

2023-12-07 Thread Gary Gregory
The optional bit I hope can be solved by refactoring Maven modules to have zero optional dependencies. Gary On Thu, Dec 7, 2023, 10:32 AM Piotr P. Karwasz wrote: > Hi Gary, > > On Thu, 7 Dec 2023 at 15:46, Gary Gregory wrote: > > > > Note that there is also the Maven moditect plugin but I don'

Re: [log4j-kotlin] Next release (`1.3.1`-vs-`1.4.0`)

2023-12-07 Thread Matt Sicker
Thanks for the info! I don’t think you’re being pedantic here; the uniform release process is very important to keeping all our components healthy. > On Dec 7, 2023, at 4:54 AM, Volkan Yazıcı wrote: > > Raman, Matt, great that you want to release the next version of the Log4j > Kotlin! Thanks f