Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Christian Grobmeier
Should the SBOM/CycloneDX files be part of the distribution folder as well? https://dist.apache.org/repos/dist/dev/logging/log4j-tools/ On Wed, Nov 15, 2023, at 16:03, Volkan Yazıcı wrote: > This is a vote to release the Apache Log4j Tools 0.6.0. > > Website: https://logging.staged.apache.org/log

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
They are. See `*-bin.zip`. On Fri, Nov 17, 2023 at 9:13 AM Christian Grobmeier wrote: > > Should the SBOM/CycloneDX files be part of the distribution folder as well? > https://dist.apache.org/repos/dist/dev/logging/log4j-tools/ > > > On Wed, Nov 15, 2023, at 16:03, Volkan Yazıcı wrote: > > This i

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 17 Nov 2023 at 09:22, Volkan Yazıcı wrote: > > They are. See `*-bin.zip`. > > On Fri, Nov 17, 2023 at 9:13 AM Christian Grobmeier > wrote: > > > > Should the SBOM/CycloneDX files be part of the distribution folder as well? > > https://dist.apache.org/repos/dist/dev/logging/log

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
Doh! As you stated [in your DM], `build.yaml` still contains the deprecated `distribution-attachment-filepath-pattern`, which doesn't match against SBOMs. I am cancelling this vote. I will issue an RC2 promptly. On Fri, Nov 17, 2023 at 9:36 AM Piotr P. Karwasz wrote: > > Hi Volkan, > > On Fri, 1

[VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j Tools 0.6.0 (RC2). Website: https://logging.staged.apache.org/log4j/tools GitHub: https://github.com/apache/logging-log4j-tools Commit: a696e081304cc0693d86533013df5b4d886cfb9c Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j-tools Nexus

Re: [VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 17 Nov 2023 at 10:21, Volkan Yazıcı wrote: > This vote is open for 24 hours and will pass unless getting a > net negative vote count. All votes are welcome and we encourage > everyone to test the release, but only the Logging Services PMC > votes are officially counted. At leas

Re: [VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 17 Nov 2023 at 10:21, Volkan Yazıcı wrote: > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... I have rechecked: * the hashes of all artifacts against locally generated ones, * the hashes an

[VOTE] Release Apache Log4j 2.22.0

2023-11-17 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j 2.22.0. Website: https://logging.staged.apache.org/log4j GitHub: https://github.com/apache/logging-log4j2 Commit: a1634d695e5702ecab505fea5aadaf9890641487 Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j Nexus: https://repository.apache.

Re: [VOTE] Release Apache Log4j JMX GUI 2.22.0

2023-11-17 Thread Gary D. Gregory
+1 - Testing source zip file - OK: ASC - OK: SHA - OK: mvn clean verify - OK: jar --describe-module --file=log4j-jmx-gui-2.22.0.jar Using: Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) Maven home: C:\java\apache-maven-3.9.5 Java version: 17.0.8, vendor: Eclipse Adoptium, runtime:

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Gary D. Gregory
Seen during 'mvn clean verify' [INFO] --- log4j-changelog:0.5.0:export (export-changelog) @ log4j-tools-bom --- [WARNING] The POM for org.apache.logging.log4j:log4j-changelog:jar:0.5.0 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details expor

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Gary D. Gregory
Also seen during 'mvn clean verify': [INFO] --- compiler:3.11.0:compile (default-compile) @ log4j-changelog-maven-plugin --- [INFO] Changes detected - recompiling the module! :dependency [INFO] Compiling 5 source files with javac [debug release 8] to target\classes [WARNING] Cannot find annotatio

Re: [VOTE] Release Apache Log4j Tools 0.6.0 (RC2)

2023-11-17 Thread Gary D. Gregory
+1 Same warnings as noted previously. - Testing src zip file - OK: ASC verify - OK: SHA check - OK: mvn clean verify Using: Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) Maven home: C:\java\apache-maven-3.9.5 Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program F

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
Good catch. Though not a big issue; `spotbugs-annotations` dependency is missing. Fixed in `main` via `fb6fee27b349bb7ec5e847a6d33f9abb81b714ec`. On Fri, Nov 17, 2023 at 2:12 PM Gary D. Gregory wrote: > > Also seen during 'mvn clean verify': > > [INFO] --- compiler:3.11.0:compile (default-compile

Re: [VOTE] Release Apache Log4j Tools 0.6.0

2023-11-17 Thread Volkan Yazıcı
`log4j-tools-bom:0.5.0` is broken: `parent` is missing. This release (i.e., `0.6.0`) fixes that. On Fri, Nov 17, 2023 at 2:11 PM Gary D. Gregory wrote: > > Seen during 'mvn clean verify' > > [INFO] --- log4j-changelog:0.5.0:export (export-changelog) @ log4j-tools-bom > --- > [WARNING] The POM fo

Re: [VOTE] Release Apache Log4j 2.22.0

2023-11-17 Thread Gary D. Gregory
Build failure for me on Windows from the src zip and 'mvn clean verify': [ERROR] Failures: [ERROR] RollingAppenderDeleteMaxDepthTest.testAppender:73 [target\rolling-with-delete-depth\test\1, target\rolling-with-delete-depth\test\2, target\rolling-with-delete-depth\test\test-1.log, target\rol

Re: [VOTE] Release Apache Log4j 2.22.0

2023-11-17 Thread Volkan Yazıcı
File-based tests on Windows are not stable. Occasionally they have hiccups. Would you mind retrying, please? You can speed up the process as follows: # Install everything without any checks ./mvnw install -DskipTests -Dspotbugs.skip -Dspotless.skip # Verify everything except `log4j-core-test` ./

[log4j] Moving Jakarta in `main` to a separate repository

2023-11-17 Thread Volkan Yazıcı
I am working on #1966 , which aims to move the Jakarta-related components of Log4j 3 to a separate repository. I have 1. moved `log4j-jakarta-{web,smtp}` and `log4j-jms` to the `logging-log4j-jakarta` repository

Re: [PR] Bump org.springframework:spring-framework-bom from 6.0.13 to 6.1.0 [logging-log4j-jakarta]

2023-11-17 Thread via GitHub
github-actions[bot] commented on PR #4: URL: https://github.com/apache/logging-log4j-jakarta/pull/4#issuecomment-1816983082 Changes are applied by CI in 4ca37fae4e0594bd9dc5ed4e5c069f69faf23df2 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Bump org.springframework:spring-framework-bom from 6.0.13 to 6.1.0 [logging-log4j-jakarta]

2023-11-17 Thread via GitHub
github-actions[bot] closed pull request #4: Bump org.springframework:spring-framework-bom from 6.0.13 to 6.1.0 URL: https://github.com/apache/logging-log4j-jakarta/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Bump org.mockito:mockito-bom from 5.5.0 to 5.7.0 [logging-log4j-jakarta]

2023-11-17 Thread via GitHub
github-actions[bot] commented on PR #3: URL: https://github.com/apache/logging-log4j-jakarta/pull/3#issuecomment-1816996007 Changes are applied by CI in f6bbf6258ee43d60118cd0a4e1a9fda99a560e28 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Bump org.mockito:mockito-bom from 5.5.0 to 5.7.0 [logging-log4j-jakarta]

2023-11-17 Thread via GitHub
github-actions[bot] closed pull request #3: Bump org.mockito:mockito-bom from 5.5.0 to 5.7.0 URL: https://github.com/apache/logging-log4j-jakarta/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump org.junit:junit-bom from 5.10.0 to 5.10.1 [logging-log4j-jakarta]

2023-11-17 Thread via GitHub
ppkarwasz commented on PR #1: URL: https://github.com/apache/logging-log4j-jakarta/pull/1#issuecomment-1817028310 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Bump org.junit:junit-bom from 5.10.0 to 5.10.1 [logging-log4j-jakarta]

2023-11-17 Thread via GitHub
github-actions[bot] closed pull request #1: Bump org.junit:junit-bom from 5.10.0 to 5.10.1 URL: https://github.com/apache/logging-log4j-jakarta/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump org.junit:junit-bom from 5.10.0 to 5.10.1 [logging-log4j-jakarta]

2023-11-17 Thread via GitHub
github-actions[bot] commented on PR #1: URL: https://github.com/apache/logging-log4j-jakarta/pull/1#issuecomment-1817035848 Changes are applied by CI in 6fb89eb4d389963b6e5f95fca1ae0cff5bbab592 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [VOTE] Release Apache Log4j 2.22.0

2023-11-17 Thread Gary D. Gregory
Hi, The only way I could get the build to pass is to let 'mvn clean verify' run while I went to lunch and nothing else was running. I would not in want to vote without running all the tests. +1 Gary On 2023/11/17 14:16:14 Volkan Yazıcı wrote: > File-based tests on Windows are not stable. > Oc