Re: Mono-vs-Multi repo setup

2023-09-01 Thread Herve Boutemy
it's not "mono vs multi (Git) repo setup" but "monolithic vs component-oriented release" longer explanation: IMHO, you should frame the discussion about: 1. keeping unique global/monolithic release of all log4j vs 2. splitting log4j into multiple parts/components released separately (with depend

Re: Mono-vs-Multi repo setup

2023-09-01 Thread Herve Boutemy
additional notice: on implementing component-oriented approach from a tooling perspective, experience proves that the hard part is not at Git level, but at generated Maven site level = how to replace a unique Maven site for the monolithic release with a site that is a combination of multiple co

Re: Mono-vs-Multi repo setup

2023-09-01 Thread Volkan Yazıcı
Thanks for sharing your thoughts Herve, much appreciated! Completely agree with you that the discussion should have rather focused on the "monolithic vs component-oriented release" subject. Thanks for pointing this out! (I am partly to blame for not capturing the context right.) Regarding how to

Spotless is annoying

2023-09-01 Thread Gary D. Gregory
How is this possible now that we use spotless in 2.x: mvn clean install -pl log4j-api,log4j-core -DskipTests [INFO] [INFO] Reactor Summary for Apache Log4j API 2.20.1-SNAPSHOT: [INFO] [INFO] Apache Log4j API

Re: Spotless is annoying

2023-09-01 Thread Piotr P. Karwasz
Hi Gary, On Fri, 1 Sept 2023 at 14:19, Gary D. Gregory wrote: > > How is this possible now that we use spotless in 2.x: It's a CRLF vs LF problem. About 6 months ago[1] I added a `.gitattributes` file[2] that forces line endings as LF also on Windows. This should solve two problems: * approach

Re: Spotless is annoying

2023-09-01 Thread Gary Gregory
Ah! Excellent news, I'll give it a go. Gary On Fri, Sep 1, 2023, 11:21 AM Piotr P. Karwasz wrote: > Hi Gary, > > On Fri, 1 Sept 2023 at 14:19, Gary D. Gregory wrote: > > > > How is this possible now that we use spotless in 2.x: > > It's a CRLF vs LF problem. About 6 months ago[1] I added a > `

Re: Mono-vs-Multi repo setup

2023-09-01 Thread Gary Gregory
Hi all, I agree that the discussion should have been framed differently. It immediately reminds me of a headache I never have: To pick up a new version of Jetty, I just update a property in my POM. That's all I need to pick up the 170 modules Jetty provides (not sure how many are jars). I know it'

Re: Spotless is annoying

2023-09-01 Thread Gary Gregory
That did not help but this sure does: -Dspotless.check.skip=true Gary On Fri, Sep 1, 2023 at 1:29 PM Gary Gregory wrote: > Ah! Excellent news, I'll give it a go. > > Gary > > On Fri, Sep 1, 2023, 11:21 AM Piotr P. Karwasz > wrote: > >> Hi Gary, >> >> On Fri, 1 Sept 2023 at 14:19, Gary D. Grego

Re: Mono-vs-Multi repo setup

2023-09-01 Thread Gary Gregory
Hi Piotr, Thank you for your detailed response :-) My comments are inline below. On Thu, Aug 31, 2023 at 4:59 PM Piotr P. Karwasz wrote: > Hi Gary, > > May I offer a different perspective on this. > I knew that ;) > > On Wed, 30 Aug 2023 at 18:56, Gary Gregory wrote: > > - I like a mon-re