Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Volkan Yazıcı
Right, it is a copy-paste mistake from the release email template. (Though this gave me the idea of generating this email from the template in CI during the release!) This VOTE is for the 0.4.0 release of Apache Log4j Tools. On Mon, Jul 3, 2023 at 12:01 AM Gary Gregory wrote: > Is it 0.4.0 or 7

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Volkan Yazıcı
Of course the artifacts are available in the Maven repository under their usual folder: https://repository.apache.org/content/repositories/orgapachelogging-1110 I simplified the VOTE email to *only* include details necessary for an ASF-compliant release. Note that Maven is a convenience, not an of

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Vladimir Sitnikov
-1, don't release, because... Volkan, I have downloaded the release artifact apache-log4j-tools-0.4.0.zip, and I fail to find the source package there. Would you please advise? See https://www.apache.org/legal/release-policy.html#what-must-every-release-contain >Every ASF release must contain

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Volkan Yazıcı
Hey Vladimir! Thanks for the review! I will address remarks inline. On Mon, Jul 3, 2023 at 1:13 PM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > I have downloaded the release artifact apache-log4j-tools-0.4.0.zip, and I > fail to find the source package there. > Would you please advi

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Volkan Yazıcı
I am cancelling this VOTE since 1. Sources are missing in the distribution 2. Email body cites the wrong version number I will promptly create a new release followed by a new VOTE thread. On Sun, Jul 2, 2023 at 8:54 PM Volkan Yazıcı wrote: > This is a lazy vote to release the Apache Log4j Too

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Gary Gregory
Hi Volkan Have a look at what we do in Commons where I generate the vote email's text to a file for the RM to review. For example: git clone https://ggreg...@gitbox.apache.org/repos/asf/commons-io.git && cd commons-io mvn -Dcommons.nexus.repo.id=$commons_nexus_repo_id org.apache.commons:commons-r

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Gary Gregory
Well, don't use my ID in your clone ;-) Gary On Mon, Jul 3, 2023 at 9:16 AM Gary Gregory wrote: > > Hi Volkan > > Have a look at what we do in Commons where I generate the vote email's text > to a file for the RM to review. For example: > > git clone https://ggreg...@gitbox.apache.org/repos/asf

Re: [VOTE][LAZY] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Ralph Goers
-1 (binding) a) the distribution directory contains only binaries. An ASF release must have a source distribution. b) I believe you worked with INFRA to get permission to use the automation signing key, but without a link to that and instructions that pointedly require keys owned by individuals

Re: Creating "the distribution" via BeanShell

2023-07-03 Thread Matt Sicker
Reply is inline below: > On Jul 2, 2023, at 2:57 PM, Volkan Yazıcı wrote: > > *Abstract:* `log4j-tools` 0.4.0 release contains a `beanshell-maven-plugin` > block that created the distribution ZIP in a way that addresses all past > concerns of PMC, it is reusable by other projects without any cha

Re: Creating "the distribution" via BeanShell

2023-07-03 Thread Ralph Goers
I replied to this thread from lists.a.o since I didn’t get Volkan’s email but I have not seen the moderation request yet. I have a few comments to this. > On Jul 3, 2023, at 8:36 AM, Matt Sicker wrote: > > Reply is inline below: > >> *The distribution must contain binaries too* >> >> I disag

RE: Creating "the distribution" via BeanShell

2023-07-03 Thread Ralph Goers
Trying this again as I have not seen my reply show up for moderation. On 2023/07/02 19:57:08 Volkan Yazıcı wrote: > *Abstract:* `log4j-tools` 0.4.0 release contains a `beanshell-maven-plugin` > block that created the distribution ZIP in a way that addresses all past > concerns of PMC, it is reusab

[VOTE] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Volkan Yazıcı
This is a vote to release the Apache Log4j Tools 0.4.0. Source repository: https://github.com/apache/logging-log4j-tools Commit: 15d888fe488660b0bb5d3fc3e95c9915f277fbee Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j Signing key: 0x077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0 Plea

[Discuss][VOTE] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Ralph Goers
I am confused. We had a vote thread for 0.4.0. Did you close that vote? Maybe I just didn’t get that email again. The commit tag for this vote is not the same as the previous commit tag. So is this really rc-2? I despise having multiple release vote threads for the same release number as it is

Re: [Discuss][VOTE] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Gary Gregory
IMO the email subject and text MUST contain the RC number. It's a small change that makes a huge difference. Gary On Mon, Jul 3, 2023, 18:33 Ralph Goers wrote: > I am confused. We had a vote thread for 0.4.0. Did you close that vote? > Maybe I just didn’t get that email again. > > The commit t

[More discussion][VOTE] Release Apache Log4j Tools 0.4.0

2023-07-03 Thread Ralph Goers
I have verified the artifact in the distribution directory. It looks fine. I am hesitant to vote on this though as you have not closed the release in the Nexus repo at repository.apache.org, which means you can still add stuff to that. Once you close that I will vote on this. I am still concer