Re: Compiling with JDK 11 or JDK 17

2023-03-08 Thread Volkan Yazıcı
I completely support both initiatives: 1. Moving the JDK to 17 (why stay at 11?) 2. Moving `log4j-jmx-gui` to a separate repository We have pulled a similar stunt in `log4j-tools`: it uses JDK 11, though targets 8. We can easily move `log4j-jmx-gui` to a separate repository by copying the project

Re: [log4j] Spotless integration

2023-03-08 Thread Volkan Yazıcı
Thanks so much for bringing this to our attention Benoit. I agree that we should pave the contribution road and make it as least painless as possible. I am in favor of removing the ratchet from Spotless and doing a bing bang. Since such a PR would practically not be reviewable, I guess ideally a c

Re: [log4j] Spotless integration

2023-03-08 Thread Piotr P. Karwasz
Hi Benoit, On Tue, 7 Mar 2023 at 08:46, Benoit Lacelle wrote: > Log4J2 team may decide to drop ratchetFrom feature, it would lead to a > massive refactoring. I would not advise doing so. I think this is the way we should go. Ratcheting has two disadvantages: * it doesn't work outside of a Git