[GitHub] [logging-log4j-transform] ppkarwasz opened a new issue, #1: Add location information to `Logger` calls

2023-01-08 Thread GitBox
ppkarwasz opened a new issue, #1: URL: https://github.com/apache/logging-log4j-transform/issues/1 The `log4j-transform-maven-plugin` should convert all call sites of a [`Logger`](https://logging.apache.org/log4j/2.x/log4j-api/apidocs/org/apache/logging/log4j/Logger.html) method to:

Builder methods: should we use setFoo, withFoo, foo, or else?

2023-01-08 Thread Matt Sicker
In my experience, I’ve usually used withFoo() methods for making immutable copies of things while I’ve used setFoo() methods for builder classes as those are mutable. In Log4j, we have a mix of these two patterns. I’d like us to be more consistent with this. Which style should we use in Log4j?