Re: [logging-log4j2] branch master updated: [LOG4J2-3459] - Add LoggingSystemProvider SPI

2022-11-01 Thread Ralph Goers
I have more questions on this. 1. PropertiesUtil cannot be deprecated. It is used by Spring Boot to register its PropertiesSource. 2. All these classes that you have marked internal are opened to various Log4j modules. That means they are NOT open to any other implementation of the Log4j-API.

Re: [logging-log4j2] branch master updated: [LOG4J2-3459] - Add LoggingSystemProvider SPI

2022-11-01 Thread Matt Sicker
Mail client selected the wrong email, whoops. Anyways, I’ll revert and break up into more commits and put the more interesting changes into a PR. — Matt Sicker > On Nov 1, 2022, at 10:21, Ralph Goers wrote: > > I have more questions on this. > > 1. PropertiesUtil cannot be deprecated. It is

Re: [logging-log4j2] branch master updated: [LOG4J2-3459] - Add LoggingSystemProvider SPI

2022-11-01 Thread Matt Sicker
I’ve reverted the last two commits as they were basically the last commit, though I’m not exactly sure if you’re referring to that one in particular. I’ll break it down into smaller pieces, though, and submit the non-trivial parts as a PR. — Matt Sicker > On Nov 1, 2022, at 10:21, Ralph Goers

Re: [logging-log4j2] branch master updated: [LOG4J2-3459] - Add LoggingSystemProvider SPI

2022-11-01 Thread Ralph Goers
Thanks Matt. I was referring to the one in the first email of this thread. Ralph > On Nov 1, 2022, at 1:41 PM, Matt Sicker wrote: > > I’ve reverted the last two commits as they were basically the last commit, > though I’m not exactly sure if you’re referring to that one in particular. > I’ll