Matt,
I absolutely would have preferred that you had created a PR for this and asked
for a review before committing it as I have a few concerns:
1. It is a massive commit. It is going to take time to digest exactly what you
have done.
2. You have created a util3 package in API with no discussio
Also, in LoggingSystem.java
private static final String[] COMPATIBLE_API_VERSIONS = {"2.6.0"};
absolutely needs to be changed to version “3.0.0”.
Ralph
> On Oct 31, 2022, at 3:49 PM, Ralph Goers wrote:
>
> Matt,
>
> I absolutely would have preferred that you had created a PR for this and
>
The util3 package is a collection of all the private classes we have. We
discussed the general idea on a recent conference call. These are pseudo
private classes. They’re meant for internal use only and are guarded by the
module info. JUnit does the same thing.
The point of Lazy is ensuring thr
See below
> On Oct 31, 2022, at 6:49 PM, Matt Sicker wrote:
>
> The util3 package is a collection of all the private classes we have. We
> discussed the general idea on a recent conference call. These are pseudo
> private classes. They’re meant for internal use only and are guarded by the
We could consolidate the Log4j-private classes into the internal package and
export it to other Log4j modules. That makes sense.
And LoggingSystem probably doesn’t need a Lazy instance of itself, right.
—
Matt Sicker
> On Oct 31, 2022, at 20:58, Apache wrote:
>
>
>
> See below
>
>> On Oct
Are you using your old email address? I keep having to moderate them through.
Yes they should be in an appropriately named package under the internal package.
Ralph
> On Oct 31, 2022, at 7:36 PM, Matt Sicker wrote:
>
> We could consolidate the Log4j-private classes into the internal package a
