.
> >
> > On Mon, Oct 18, 2021 at 7:22 PM Eduard Gizatullin
> > wrote:
> >
> > > Hello Volkan,
> > >
> > > Thanks for your explanation, I really appreciate it and I think I can
> > make
> > > a pull request tomorrow.
> > >
> &
I see that you check coverage via jacoco-maven-plugin
<https://github.com/edwgiz/maven-shaded-log4j-transformer/blob/master/pom.xml#L211>.
Repeating this practice for this module (only?) is fine by me.
On Tue, Oct 19, 2021 at 9:52 AM Eduard Gizatullin wrote:
> Done, https://github.c
gt; make
> > a pull request tomorrow.
> >
> > With hindsight, couldn't you please consider below points:
> >
> > 1. maven-shaded-log4j-transformer is not a plugin, it's an extension for
> > the existing shaded plugin. Also the depend
ouldn't you please consider below points:
>
> 1. maven-shaded-log4j-transformer is not a plugin, it's an extension for
> the existing shaded plugin. Also the dependency must be explicitly
> declared.
> org.apache.maven.plugins
>
consider below points:
>
> 1. maven-shaded-log4j-transformer is not a plugin, it's an extension for
> the existing shaded plugin. Also the dependency must be explicitly
> declared.
>org.apache.maven.plugins
>
Hello Volkan,
Thanks for your explanation, I really appreciate it and I think I can make
a pull request tomorrow.
With hindsight, couldn't you please consider below points:
1. maven-shaded-log4j-transformer is not a plugin, it's an extension for
the existing shaded plugin. Also the
ividual
> >>> projects.
> >>> My proposal:
> >>>
> >>> - *GitHub project name:* logging-log4j2-maven-plugins
> >>> - *Group ID:* org.apache.logging.maven
> >>> - *Artifact ID:* maven-log4j-transformer-plugin (in a su
gt;
>>> - *GitHub project name:* logging-log4j2-maven-plugins
>>> - *Group ID:* org.apache.logging.maven
>>> - *Artifact ID:* maven-log4j-transformer-plugin (in a submodule, and
>>> note the `maven-*-plugin` convention for unofficial Maven plugins)
>>> - *Tra
ransformer class name:* Log4jPluginCacheFileCombiner
> >
> >
> >
> > On Fri, Oct 15, 2021 at 4:04 PM Apache
> wrote:
> >
> > > Question: Do we want it as a sub-module or as a new git repo with its
> own
> > > release?
> > >
> >>>> Hi Ed,
> >>>>
> >>>> Your files must have the Apache License header comment, otherwise
> >> running
> >>>> 'mvn apache-rat:check' will fail.
> >>>>
> >>>> Gary
> >>&g
t;>
>>>> Hi Ed,
>>>>
>>>> Your files must have the Apache License header comment, otherwise
>> running
>>>> 'mvn apache-rat:check' will fail.
>>>>
>>>> Gary
>>>>
>>>>
>>>>
5, 2021 at 4:48 PM Gary Gregory
> wrote:
> >>
> >> Hi Ed,
> >>
> >> Your files must have the Apache License header comment, otherwise
> running
> >> 'mvn apache-rat:check' will fail.
> >>
> >> Gary
> >>
> &g
t;
>>> Question: Do we want it as a sub-module or as a new git repo with its own
>>> release?
>>>
>>> Ralph
>>>
>>>> On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin
>> wrote:
>>>>
>>>> Hello dear log4j te
2021, at 6:50 AM, Eduard Gizatullin
> wrote:
> > >
> > > Hello dear log4j team
> > >
> > > Volkan Yazıcı asked me to make maven-shaded-log4j-transformer
> > > <https://github.com/edwgiz/maven-shaded-log4j-transformer> a part of
> > > l
t; Gary
>>
>>
>>> On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin wrote:
>>>
>>> Hello dear log4j team
>>>
>>> Volkan Yazıcı asked me to make maven-shaded-log4j-transformer
>>> <https://github.com/edwgiz/maven-shaded-log4j-transf
Oct 15, 2021, 09:49 Eduard Gizatullin wrote:
>
>> Hello dear log4j team
>>
>> Volkan Yazıcı asked me to make maven-shaded-log4j-transformer
>> <https://github.com/edwgiz/maven-shaded-log4j-transformer> a part of
>> log4j2 and I tend to accomplish the proposal.
t;
> On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin wrote:
>
> > Hello dear log4j team
> >
> > Volkan Yazıcı asked me to make maven-shaded-log4j-transformer
> > <https://github.com/edwgiz/maven-shaded-log4j-transformer> a part of
> > log4j2 and I tend t
Hi Ed,
Your files must have the Apache License header comment, otherwise running
'mvn apache-rat:check' will fail.
Gary
On Fri, Oct 15, 2021, 09:49 Eduard Gizatullin wrote:
> Hello dear log4j team
>
> Volkan Yazıcı asked me to make maven-shaded-log4j-transformer
> <
rote:
> Question: Do we want it as a sub-module or as a new git repo with its own
> release?
>
> Ralph
>
> > On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin wrote:
> >
> > Hello dear log4j team
> >
> > Volkan Yazıcı asked me to make maven-shaded-log4j
Question: Do we want it as a sub-module or as a new git repo with its own
release?
Ralph
> On Oct 15, 2021, at 6:50 AM, Eduard Gizatullin wrote:
>
> Hello dear log4j team
>
> Volkan Yazıcı asked me to make maven-shaded-log4j-transformer
> <https://github.com/edwg
Hello dear log4j team
Volkan Yazıcı asked me to make maven-shaded-log4j-transformer
<https://github.com/edwgiz/maven-shaded-log4j-transformer> a part of
log4j2 and I tend to accomplish the proposal.
Can you please confirm that
new sub-module name log4j-maven-shade-plugin is o
21 matches
Mail list logo
