Re: Test failures in log4j-taglib

2017-10-23 Thread Remko Popma
The error went away on my machine and the Jenkins build started passing after reverting back to 3.2.18.RELEASE > On Oct 24, 2017, at 4:51, Ralph Goers wrote: > > OK. So I am guessing that the errors are happening on a unit test that uses > Spring’s mock classes and those were upgraded in 4.

Re: Test failures in log4j-taglib

2017-10-23 Thread Ralph Goers
OK. So I am guessing that the errors are happening on a unit test that uses Spring’s mock classes and those were upgraded in 4.x to support Servlet 3.0. Ralph > On Oct 23, 2017, at 11:46 AM, Mikael Ståldal wrote: > > It happened when Spring Framework was upgraded to 4.x. > > > On 2017-10-23

Re: Test failures in log4j-taglib

2017-10-23 Thread Gary Gregory
On Mon, Oct 23, 2017 at 12:14 PM, Ralph Goers wrote: > So does this mean that log4j-taglib no longer supports servlet 2.5? How > did this happen with no changes? > No idea. Matt mentioned the change did not break anything so I made the change to the POM. I can see [1] that 2.5 is from 2005 (12

Re: Test failures in log4j-taglib

2017-10-23 Thread Mikael Ståldal
It happened when Spring Framework was upgraded to 4.x. On 2017-10-23 20:14, Ralph Goers wrote: So does this mean that log4j-taglib no longer supports servlet 2.5? How did this happen with no changes? Ralph On Oct 23, 2017, at 8:21 AM, Gary Gregory wrote: On Thu, Oct 19, 2017 at 2:14 PM,

Re: Test failures in log4j-taglib

2017-10-23 Thread Ralph Goers
So does this mean that log4j-taglib no longer supports servlet 2.5? How did this happen with no changes? Ralph > On Oct 23, 2017, at 8:21 AM, Gary Gregory wrote: > > On Thu, Oct 19, 2017 at 2:14 PM, Ralph Goers > > wrote: > >> I am wondering why this is su

Re: Test failures in log4j-taglib

2017-10-23 Thread Gary Gregory
On Thu, Oct 19, 2017 at 2:14 PM, Ralph Goers wrote: > I am wondering why this is suddenly failing. Was it changed recently? > > Ralph > > > On Oct 19, 2017, at 1:00 PM, Mikael Ståldal wrote: > > > > The missing class, javax.servlet.SessionCookieConfig is new in Servlet > API 3.x. In log4j-taglib

Re: Test failures in log4j-taglib

2017-10-21 Thread Gary Gregory
Weird. I have been running so manyv local builds for changes I check in. I must have missed that one! Feel free to revert or investigate unless I get to it first. Gary On Oct 21, 2017 08:11, "Mikael Ståldal" wrote: > The problem started here: > https://builds.apache.org/job/Log4j%202.x/3135/ >

Re: Test failures in log4j-taglib

2017-10-21 Thread Mikael Ståldal
The problem started here: https://builds.apache.org/job/Log4j%202.x/3135/ https://github.com/apache/logging-log4j2/commit/9126644cf85a52859690bc8499b0c701a8db3ae7 So I guess that the upgrade from Spring Framework 3.x to 4.x by Gary caused it. On 2017-10-19 22:14, Ralph Goers wrote: I am wond

Re: Test failures in log4j-taglib

2017-10-19 Thread Matt Sicker
On 19 October 2017 at 15:00, Mikael Ståldal wrote: > That's causing the issue, when I changed it to 3.0.1 the test pass. Is > there any particular reason for keeping this at version 2.5? I don't know any specific reason to stick with the old dependency; Nick wrote most of the servlet-related in

Re: Test failures in log4j-taglib

2017-10-19 Thread Ralph Goers
I am wondering why this is suddenly failing. Was it changed recently? Ralph > On Oct 19, 2017, at 1:00 PM, Mikael Ståldal wrote: > > The missing class, javax.servlet.SessionCookieConfig is new in Servlet API > 3.x. In log4j-taglib pom, we have this dependency: > > >javax.servlet

Re: Test failures in log4j-taglib

2017-10-19 Thread Mikael Ståldal
The missing class, javax.servlet.SessionCookieConfig is new in Servlet API 3.x. In log4j-taglib pom, we have this dependency: javax.servlet servlet-api 2.5 provided That's causing the issue, when I changed it to 3.0.1 the test pass. Is there any pa

Re: Test failures in log4j-taglib

2017-10-19 Thread Ralph Goers
I’m not sure why that would be. AFAIK that hasn’t been modified in a long time. Ralph > On Oct 19, 2017, at 12:15 PM, Mikael Ståldal wrote: > > I get a bunch of these errors in log4j-taglib when trying to build current > master branch locally: > > [ERROR] Errors: > [ERROR] CatchingTagTest.s

Test failures in log4j-taglib

2017-10-19 Thread Mikael Ståldal
I get a bunch of these errors in log4j-taglib when trying to build current master branch locally: [ERROR] Errors: [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound javax/servlet/SessionCookieConfig [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound javax/servlet/SessionCookieConfig [ERROR