Re: StrSubstitutor recursion

2021-12-19 Thread Stig Rohde Døssing
I've raised a PR at https://github.com/apache/logging-log4j2/pull/644, let me know what you think. Den søn. 19. dec. 2021 kl. 17.19 skrev Ralph Goers < ralph.go...@dslextreme.com>: > Yes. Even setting it to a ridiculous number like 10 would prevent a lot of > problems. > > Ralph > > > On Dec 19,

Re: StrSubstitutor recursion

2021-12-19 Thread Ralph Goers
Yes. Even setting it to a ridiculous number like 10 would prevent a lot of problems. Ralph > On Dec 19, 2021, at 9:17 AM, Stig Rohde Døssing > wrote: > > Hi Ralph, > > Thank you for elaborating, that makes sense, and I can see how that is > useful. Limiting recursion to some small number of

Re: StrSubstitutor recursion

2021-12-19 Thread Stig Rohde Døssing
Hi Ralph, Thank you for elaborating, that makes sense, and I can see how that is useful. Limiting recursion to some small number of levels, as a default controlled by system property (or some other mechanism), still seems like it could be worthwhile, it would close any potential for the issue in

Re: StrSubstitutor recursion

2021-12-19 Thread Gary Gregory
Something like a setting in the prop file itself or yet another system property "variable substitution depth"? Gary On Sun, Dec 19, 2021, 11:10 Vladimir Sitnikov wrote: > >Could it make sense to limit recursion to a few levels (e.g. 3 or 5) by > default, > > +1 > > Unlimited recursion is a disa

Re: StrSubstitutor recursion

2021-12-19 Thread Gary Gregory
Yeah, this is super cool. At work, many of our customers want DTAP configurations so we paramertize the config files for our software so we do not need four sets of configuration folders and all their files. Gary On Sun, Dec 19, 2021, 11:04 Ralph Goers wrote: > In my configuration I have > > >

Re: StrSubstitutor recursion

2021-12-19 Thread Vladimir Sitnikov
>Could it make sense to limit recursion to a few levels (e.g. 3 or 5) by default, +1 Unlimited recursion is a disaster waiting to happen. Adding a hard limit makes sense. Vladimir

Re: StrSubstitutor recursion

2021-12-19 Thread Ralph Goers
In my configuration I have ${sys:environment:-lab} ${sys:flow_match:-ACCEPT} NEUTRAL INFO INFO https://issues.apache.org/jira/browse/LOG4J2-3230 looks like it > disables recursive interpolation for strings that are not sourced from the > log4j configuration. I'm wondering why recur

StrSubstitutor recursion

2021-12-19 Thread Stig Rohde Døssing
Hi, The fix for https://issues.apache.org/jira/browse/LOG4J2-3230 looks like it disables recursive interpolation for strings that are not sourced from the log4j configuration. I'm wondering why recursive interpolation is desirable at all, at least as a default? Is it so you can have your config do