Hi Ralph,
On Tue, 23 Aug 2022 at 08:14, Ralph Goers wrote:
> I don’t see that as a problem at all. Log4jLogEvent’s constructor accepts a
> List of properties. We use this to inject properties configured on Loggers
> into the Context Map of the LogEvent. I see no reason why these key/value
> pa
I don’t see that as a problem at all. Log4jLogEvent’s constructor accepts a
List of properties. We use this to inject properties configured on Loggers into
the Context Map of the LogEvent. I see no reason why these key/value pairs
shouldn’t be treated the same way.
Ralph
> On Aug 22, 2022, at
Hi everybody,
Besides the enhanced NDC, there is another SLF4J 2.0 feature I don't
really know how to deal with:
https://www.slf4j.org/api/org/slf4j/spi/LoggingEventBuilder.html#addKeyValue-java.lang.String-java.lang.Object-
These key/value pairs in the `LoggingEventBuilder` seem to be separate
I don’t think that’s the only sane option.
Another sane option is to ignore it.
There’s nothing that says Log4j has to implement any enhanced SLF4J APIs.
He wants to be the lowest common denominator in logging APIs, then he can’t add
APIs that aren’t supported in the major implementations.
It would be weird IMO to provide a PatternConverter for an NDC stack that is
supported by SLF4J but not Log4j.
Unfortunately, I think the only sane thing to do is option 1.
Ralph
> On Aug 22, 2022, at 8:45 AM, Piotr P. Karwasz wrote:
>
> Hi all,
>
> On Sat, 16 Apr 2022 at 00:17, Carter Kozak
Hi all,
On Sat, 16 Apr 2022 at 00:17, Carter Kozak wrote:
> I can understand how the stack-based mdc might be convenient and useful, but
> I don't think it fits my use-cases. That said, I wonder if the API could be
> improved in such a way that it could leverage the application stack instead
>
of the repository.
>
> Personally I am not convinced that introducing a second stack valued MDC
> has many applications and I believe that Ralph shares my opinion. Therefore
> I would propose to implement it using the currently available MDC (cf. PR
> #820 <https://github.com/ap
4j-2.0` branch of the repository.
Personally I am not convinced that introducing a second stack valued MDC
has many applications and I believe that Ralph shares my opinion. Therefore
I would propose to implement it using the currently available MDC (cf. PR
#820 <https://github.com/apache/logging-log4j2
