Re: SocketOptions builder

2017-08-21 Thread Remko Popma
Not breaking binary comparability (so leaving it as it is) is fine. (Shameless plug) Every java main() method deserves http://picocli.info > On Aug 22, 2017, at 0:32, Gary Gregory wrote: > > To be clear, what is fine? Leaving it as is, or breaking Core BC and make > the change from "set" to "w

Re: SocketOptions builder

2017-08-21 Thread Gary Gregory
To be clear, what is fine? Leaving it as is, or breaking Core BC and make the change from "set" to "with" now? Gary On Thu, Aug 17, 2017 at 4:21 PM, Remko Popma wrote: > That's fine I think. > > (Shameless plug) Every java main() method deserves http://picocli.info > > > On Aug 18, 2017, at 7:1

Re: SocketOptions builder

2017-08-17 Thread Remko Popma
That's fine I think. (Shameless plug) Every java main() method deserves http://picocli.info > On Aug 18, 2017, at 7:18, Gary Gregory wrote: > > What I did not do is change the "set" methods to "with" to avoid breaking > user sources. We should do that for 3.0 I think. > > Gary > >> On Thu, A

Re: SocketOptions builder

2017-08-17 Thread Gary Gregory
What I did not do is change the "set" methods to "with" to avoid breaking user sources. We should do that for 3.0 I think. Gary On Thu, Aug 17, 2017 at 4:10 PM, Remko Popma wrote: > I like the idiom where setter methods return `this`, so users can chain > methods; thanks for making that change.

Re: SocketOptions builder

2017-08-17 Thread Remko Popma
I like the idiom where setter methods return `this`, so users can chain methods; thanks for making that change. On Fri, Aug 18, 2017 at 5:41 AM, Gary Gregory wrote: > Hi All and FYI: > > I plan on redoing the SocketOptions class as a real builder by making all > accessors return this. > > Any o

SocketOptions builder

2017-08-17 Thread Gary Gregory
Hi All and FYI: I plan on redoing the SocketOptions class as a real builder by making all accessors return this. Any objections? Gary