Re: Review request for LOG4J2-2962

2020-11-24 Thread Volkan Yazıcı
@Carter, @Ralph, thanks so much! I have merged the PR to master and cherry-picked to release-2.x. On Fri, Nov 20, 2020 at 12:02 PM Volkan Yazıcı wrote: > Hey Ralph! Did you manage to spare some time for this? > > On Tue, Nov 17, 2020 at 11:58 PM Ralph Goers > wrote: > >> I’ll see if I can find

Re: Review request for LOG4J2-2962

2020-11-20 Thread Volkan Yazıcı
Hey Ralph! Did you manage to spare some time for this? On Tue, Nov 17, 2020 at 11:58 PM Ralph Goers wrote: > I’ll see if I can find time later tonight. > > Ralph > > > On Nov 17, 2020, at 2:59 PM, Volkan Yazıcı > wrote: > > > > In LOG4J2-2962, Magnus Kvalheim requests a functionality for the "m

Re: Review request for LOG4J2-2962

2020-11-17 Thread Ralph Goers
I’ll see if I can find time later tonight. Ralph > On Nov 17, 2020, at 2:59 PM, Volkan Yazıcı wrote: > > In LOG4J2-2962, Magnus Kvalheim requests a functionality for the "map" > resolver similar to the one in "mdc". Guess what? They both operate on > `ReadOnlyStringMap`s and there goes my MR: >

Review request for LOG4J2-2962

2020-11-17 Thread Volkan Yazıcı
In LOG4J2-2962, Magnus Kvalheim requests a functionality for the "map" resolver similar to the one in "mdc". Guess what? They both operate on `ReadOnlyStringMap`s and there goes my MR: https://github.com/apache/logging-log4j2/pull/441 Here I merge the backends of both resolvers into one: `ReadOnlyS