Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-04-03 Thread Apache
Yeah, sorry for not getting to that. I will still look at it though. Ralph > On Apr 3, 2021, at 3:19 AM, Volkan Yazıcı wrote: > > Ralph, I know you are pretty busy with the Java 11 migration on master. > I will merge this branch onto release-2.x and then cherry-pick into master. > I need to ge

Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-04-03 Thread Volkan Yazıcı
Merging release-2.x worked, as expected. Cherry-picking the commit into master turned out to be quite hairy than I expected. I think I finally got it and pushed the changes to master. On Sat, Apr 3, 2021 at 12:18 PM Volkan Yazıcı wrote: > Ralph, I know you are pretty busy with the Java 11 migrat

Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-04-03 Thread Volkan Yazıcı
Ralph, I know you are pretty busy with the Java 11 migration on master. I will merge this branch onto release-2.x and then cherry-pick into master. I need to get this in, so that I can continue working on other JTL tickets. On Mon, Mar 22, 2021 at 9:54 PM Ralph Goers wrote: > I will try to get t

Re: Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-03-22 Thread Ralph Goers
I will try to get to it this evening. Ralph > On Mar 22, 2021, at 1:26 PM, Volkan Yazıcı wrote: > > Hello, > > I have created a GitHub PR (#476) > addressing LOG4J2-3004 > JsonTemplateLayout plugin support >

Review request: LOG4J2-3004 JsonTemplateLayout plugin support

2021-03-22 Thread Volkan Yazıcı
Hello, I have created a GitHub PR (#476) addressing LOG4J2-3004 JsonTemplateLayout plugin support . I needed to make a small (backward-compatible) change to TypeConverterRegistry and I have some