Re: Requiring signed commits

2023-01-15 Thread Volkan Yazıcı
It sounds like we have a lazy consensus here. Piotr, I see your point. I think we need to point this out in a GitHub Pull Request template , whi

Re: Requiring signed commits

2023-01-13 Thread Piotr P. Karwasz
Hi Volkan, On Fri, 13 Jan 2023 at 10:56, Volkan Yazıcı wrote: > *Question:* Shall we require signed commits? I am obviously Ok with signing, but what should we do with unsigned PRs? I would prefer to document the requirement somewhere (in the PR template?) so that we don't have to `rebase -f` ev

Re: Requiring signed commits

2023-01-13 Thread Gary Gregory
Sounds reasonable to sign commits if you think it could catch problems sooner, I onky sign tags usually. Gary On Fri, Jan 13, 2023, 04:56 Volkan Yazıcı wrote: > [I am resurrecting this post from March 2022 > .] > > I am in favor

Requiring signed commits

2023-01-13 Thread Volkan Yazıcı
[I am resurrecting this post from March 2022 .] I am in favor of enabling *the "requires signature"* setting. I see Carter, Matt, Piotr, and myself always signing the commits. Ralph and Gary need to join the band too. it is pretty s