Re: Switch from `maven-bundle-plugin` to `bnd-maven-plugin`

2023-09-14 Thread Matt Sicker
I’m in favor of using bnd-maven-plugin (as the person who introduced it in log4j-api-kotlin) mainly due to the fact that it’s a more first-class OSGi project that’s still recommended for modern OSGi development. > On Sep 13, 2023, at 4:12 AM, Piotr P. Karwasz wrote: > > Hi, > > As you probabl

Re: Switch from `maven-bundle-plugin` to `bnd-maven-plugin`

2023-09-13 Thread Ralph Goers
I am fine with switching to the bed-maven-plugin. It simply may not have existed when we first started using the Felix plugin. It feels a little strange to generate JPMS descriptors from an OSGI tool, but if it works - OK. Ralph > On Sep 13, 2023, at 2:12 AM, Piotr P. Karwasz wrote: > > Hi,

Re: Switch from `maven-bundle-plugin` to `bnd-maven-plugin`

2023-09-13 Thread Piotr P. Karwasz
Hi Gary, On Wed, 13 Sept 2023 at 14:41, Gary Gregory wrote: > > Speaking of JPMS, you might be interested that over at Apache Commons, > we've started using the Moditect Maven plugin to generate module-info > files automatically (see the parent POM if you're interested). I have seen you mention

Re: Switch from `maven-bundle-plugin` to `bnd-maven-plugin`

2023-09-13 Thread Gary Gregory
Speaking of JPMS, you might be interested that over at Apache Commons, we've started using the Moditect Maven plugin to generate module-info files automatically (see the parent POM if you're interested). Gary On Wed, Sep 13, 2023 at 5:32 AM Volkan Yazıcı wrote: > > I support all 3 proposals: >

Re: Switch from `maven-bundle-plugin` to `bnd-maven-plugin`

2023-09-13 Thread Gary Gregory
Hi Piotr, I'm curious about this change. It seems like a fine idea because of the match with the underlying bnd tool. Is there another advantage? Depending on our experience here, I might switch Apache Commons as well, so I'm interested to how this turns out :-) Gary On Wed, Sep 13, 2023 at 5:1

Re: Switch from `maven-bundle-plugin` to `bnd-maven-plugin`

2023-09-13 Thread Volkan Yazıcı
I support all 3 proposals: 1. using `bnd-maven-plugin` 2. using it everywhere (i.e., making it a part of `logging-parent`, I presume) 3. using it for JMPS descriptors Does #3 only need to happen on `3.x`? Can't we implement this for `2.x` too? On Wed, Sep 13, 2023 at 11:13 AM Piotr