I believe I have asked for a log4j-its module for a while now since that is the
only way you can validate modules actually work together. I am fine with it
being in a separate repo.
Ralph
> On Aug 8, 2024, at 11:35 PM, Piotr P. Karwasz wrote:
>
> Hi all,
>
> Unless I am mistaken, adding test
Hi Matt,
On Fri, 9 Aug 2024 at 20:28, Matt Sicker wrote:
>
> Commons libraries are generally self-contained to the point where modularity
> isn’t a problem. Things get complicated once you start involving split up
> modules like APIs, SPIs, alternate implementations, and reflection-heavy
> des
Commons libraries are generally self-contained to the point where modularity
isn’t a problem. Things get complicated once you start involving split up
modules like APIs, SPIs, alternate implementations, and reflection-heavy design
patterns that otherwise bypass language rules around member acces
We do not test the module path.
"Among the problems that tools like BND or Moditect might"
So? Then we or others report and fix those tools. If moditect does not work
100% it's no reason to do all this JPMS junk manually. These are all open
source tools, so we can all play nicely together and rep
Hi Gary,
On Fri, 9 Aug 2024 at 15:24, Gary Gregory wrote:
> I've had many requests to support JPMS in Commons and none that I recall
> since I've been releasing jars using Moditect, so I can only assume it
> works well enough. My impression is that people only care to get rid of
> warnings or err
I know enough of the Eclipse setup to say that it works and that's it.
I've had many requests to support JPMS in Commons and none that I recall
since I've been releasing jars using Moditect, so I can only assume it
works well enough. My impression is that people only care to get rid of
warnings or
Hi Gary,
On Fri, 9 Aug 2024 at 13:18, Gary Gregory wrote:
> I use Eclipse to create PRs for projects like Jetty 12 which has 200+ Maven
> modules. How is this not a problem there?
I don't see any `module-info.java` file in Jetty tests. Are they even
running tests on the module path?
> In Common
I use Eclipse to create PRs for projects like Jetty 12 which has 200+ Maven
modules. How is this not a problem there?
In Commons, we use the Moditect plugin to generate the JPMS junk, no
problems. No need for the insanity of special test projects.
It feels like we are doing something wrong here..
Hi Gary,
On Fri, 9 Aug 2024 at 12:00, Gary Gregory wrote:
>
> I hope you mean a new maven module and not a whole new git repo...
Unfortunately I mean repo. The problem is that IDEs (even commercial
ones like IntelliJ IDEA) barely handle JPMS and have big problems with
the way we generate JPMS mo
I hope you mean a new maven module and not a whole new git repo...
Gary
On Fri, Aug 9, 2024, 2:35 AM Piotr P. Karwasz
wrote:
> Hi all,
>
> Unless I am mistaken, adding tests that run under JPMS is problematic
> in the `apache/logging-log4j2` repository. Even if I create a new
> Maven module for
10 matches
Mail list logo
