Hi all,
On Wed, 8 Nov 2023 at 09:05, Volkan Yazıcı wrote:
> I completely agree with Matt. With or without IDE plugins, we run `./mvnw
> spotless:apply` anyway. Hence, lack of Eclipse support is not a blocker,
> IMO. Gary is covered.
>
> +1 deterministic formatter (don't have an opinion on Palanti
On Wed, Nov 8, 2023, at 09:04, Volkan Yazıcı wrote:
> I completely agree with Matt. With or without IDE plugins, we run `./mvnw
> spotless:apply` anyway. Hence, lack of Eclipse support is not a blocker,
> IMO. Gary is covered.
>
> +1 deterministic formatter (don't have an opinion on Palantir-vs-
I completely agree with Matt. With or without IDE plugins, we run `./mvnw
spotless:apply` anyway. Hence, lack of Eclipse support is not a blocker,
IMO. Gary is covered.
+1 deterministic formatter (don't have an opinion on Palantir-vs-Google)
Piotr, it has been two months or so since we are discus
In the worst case scenario, we can still format from maven before committing
(which is what I used to do before finding that there were IntelliJ plugins for
this). In fact, I have to do that all the time lately anyways by running `mvn
spotless:apply`.
> On Nov 6, 2023, at 9:00 AM, Carter Kozak
I'd be happy to review+release changes to get the eclipse plugin in that repo
into a good place as long as it doesn't make the build process a great deal
more complicated. We don't have many folks internally using eclipse so support
hasn't been a priority, but the easier it is to use across comm
The latest: 4.29.0
Gary
On Mon, Nov 6, 2023, 6:55 AM Piotr P. Karwasz
wrote:
> Hi Gary,
>
> On Mon, 6 Nov 2023 at 11:45, Gary Gregory wrote:
> >
> > Well, I use Eclipse, so... I won't be using whatever this does or when it
> > does it.
>
> What version of Eclipse do you use? The Eclipse plugi
Hi Gary,
On Mon, 6 Nov 2023 at 11:45, Gary Gregory wrote:
>
> Well, I use Eclipse, so... I won't be using whatever this does or when it
> does it.
What version of Eclipse do you use? The Eclipse plugin is one class, I
can probably fix it, compile it and release it.
Piotr
Well, I use Eclipse, so... I won't be using whatever this does or when it
does it.
Gary
On Mon, Nov 6, 2023, 3:00 AM Piotr P. Karwasz
wrote:
> Hi Matt,
>
> On Fri, 3 Nov 2023 at 19:44, Matt Sicker wrote:
> >
> > Alright, after looking at the differences, I’m strongly in favor of the
> Palantir
Hi Matt,
On Fri, 3 Nov 2023 at 19:44, Matt Sicker wrote:
>
> Alright, after looking at the differences, I’m strongly in favor of the
> Palantir version. The differences in how it handles lambdas solves one of the
> main complaints I ever had about the Google version.
The only disadvantage of t
Alright, after looking at the differences, I’m strongly in favor of the
Palantir version. The differences in how it handles lambdas solves one of the
main complaints I ever had about the Google version.
> On Oct 25, 2023, at 11:47 PM, Piotr P. Karwasz
> wrote:
>
> Hi Matt,
>
> On Thu, 26 Oct
Hi Matt,
On Thu, 26 Oct 2023 at 01:03, Matt Sicker wrote:
>
> Seems reasonable to me. I can’t really tell what the difference is between
> the two resulting outputs, though.
There was no difference (I must have used the same Spotless config
twice), so I corrected it.
Anyway the differences are
Seems reasonable to me. I can’t really tell what the difference is between the
two resulting outputs, though.
> On Oct 25, 2023, at 3:06 PM, Piotr P. Karwasz wrote:
>
> Hi all,
>
> On Thu, 21 Sept 2023 at 07:15, Piotr P. Karwasz
> wrote:
>> Spotless supports many formatter plugins, the main
Hi all,
On Thu, 21 Sept 2023 at 07:15, Piotr P. Karwasz wrote:
> Spotless supports many formatter plugins, the main ones being Eclipse,
> Google and Palantir formatters. All three are IDE agnostic.
I created two PRs using the Google (AOSP variant)[1] and Palantir[2] formatter.
If we were to ado
Hi Gary,
On Wed, 20 Sept 2023 at 16:23, Gary Gregory wrote:
> Hmm... interesting but I can't help but think that we are making our
> build more complex by jumping through hoops to fix problems of our own
> making: We already use spotless in the builds. Now we want to use
> OpenRewrite but that ma
We use the Google Java formatter in Spinnaker, and while I know some of my
teammates despise the particular code style chosen there, my preference is
consistency over anything. A deterministic formatter would be best for avoiding
merge conflicts. If we adopt a formatter, as long as it’s IDE-agno
Hmm... interesting but I can't help but think that we are making our
build more complex by jumping through hoops to fix problems of our own
making: We already use spotless in the builds. Now we want to use
OpenRewrite but that makes a "mess", so now we want to use _another_
plugin to fix that, that
16 matches
Mail list logo
