Re: Adding to Logging KEYS file

2024-10-11 Thread Robert Middleton
The source code is the same for all platforms, so we only need to run it on one builder. I took a brief look earlier, but I'm busy this weekend so I can take a closer look next week. -Robert Middleton On Fri, Oct 11, 2024 at 2:10 PM Piotr P. Karwasz wrote: > > Hi Stephen, > > On Wed, 9 Oct 2024

Re: Adding to Logging KEYS file

2024-10-11 Thread Piotr P. Karwasz
Hi Stephen, On Wed, 9 Oct 2024 at 08:36, Stephen Webb wrote: > > That would be much simpler. I was not aware that option was available. Is > there an example I can copy? I added a prototype as PR #414[1]: * I added a `package.sh` script that can be used to generate the source archives in a repr

Re: Adding to Logging KEYS file

2024-10-09 Thread Piotr P. Karwasz
Hi Volkan, On Wed, 9 Oct 2024 at 16:46, Volkan Yazıcı wrote: > > Piotr, note that the build must be reproducible > for > CI-based signing. If this is not the case for Log4cxx, could you also > address that in your PR, pleas

Re: Adding to Logging KEYS file

2024-10-09 Thread Volkan Yazıcı
Piotr, note that the build must be reproducible for CI-based signing. If this is not the case for Log4cxx, could you also address that in your PR, please? On Wed, Oct 9, 2024 at 9:09 AM Piotr P. Karwasz wrote: > On Wed, 9

Re: Adding to Logging KEYS file

2024-10-09 Thread Piotr P. Karwasz
Hi Stephen, On Wed, 9 Oct 2024 at 09:09, Piotr P. Karwasz wrote: > [1] > https://github.com/apache/logging-parent/blob/428d9ede494f54358c6f004b07f7e40f8f33d3ab/.github/workflows/merge-dependabot-reusable.yaml#L70-L79 The `deploy-release-reusable` workflow[1] should be a better example on how we

Re: Adding to Logging KEYS file

2024-10-09 Thread Piotr P. Karwasz
On Wed, 9 Oct 2024 at 08:36, Stephen Webb wrote: > > That would be much simpler. I was not aware that option was available. Is > there an example I can copy? We use `actions/setup-java` in our workflows[1], which can also install a GPG key on the Github runner (and clears it when the action ends/

Re: Adding to Logging KEYS file

2024-10-08 Thread Stephen Webb
That would be much simpler. I was not aware that option was available. Is there an example I can copy? On Wed, Oct 9, 2024 at 5:04 PM Piotr P. Karwasz wrote: > Hi Stephen, > > On Wed, 9 Oct 2024 at 07:12, Stephen Webb wrote: > > > > I have sent the public key D4305EBC16B4A78D to hkps://keys.ope

Re: Adding to Logging KEYS file

2024-10-08 Thread Piotr P. Karwasz
Hi Stephen, On Wed, 9 Oct 2024 at 07:12, Stephen Webb wrote: > > I have sent the public key D4305EBC16B4A78D to hkps://keys.openpgp.org > > Is this the correct way to get the KEYS file updated? You also need to append it to the KEYS file in the Subversion release repository: https://dist.apache.