Re: [log4j] Nested logging and async. message formatting

2024-02-06 Thread Volkan Yazıcı
Thanks so much for thinking along with me Piotr in this pretty sophisticated puzzler. Regarding your following statements... On Mon, Feb 5, 2024 at 8:43 PM Piotr P. Karwasz wrote: > I would prefer for the two event factories **not** to call > `Message#getFormattedMessage` at all. > ... > Both iss

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Piotr P. Karwasz
Hi Volkan, On Mon, 5 Feb 2024 at 20:13, Volkan Yazıcı wrote: > What about the other two issues I mentioned: > >1. `log4j2.formatMsgAsync` and `@AsynchronouslyFormattable` don't always >work (`log4j2.formatMsgAsync=false` is ignored for reusable messages, which >are formatted always ea

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Piotr P. Karwasz
Hi Volkan, On Mon, 5 Feb 2024 at 16:18, Volkan Yazıcı wrote: > I thought of matching the behavior between the two log event factories by > making the `DefaultLogEventFactory` format the message at creation. This > would imply both message factories will be formatting the message eagerly. > (Forma

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Volkan Yazıcı
Okay, nested logging is officially not supported. I will remove the nested logging tests blocking the `2.x-StatusLogger-revamp` branch. What about the other two issues I mentioned: 1. `log4j2.formatMsgAsync` and `@AsynchronouslyFormattable` don't always work (`log4j2.formatMsgAsync=false` i

Re: [log4j] Nested logging and async. message formatting

2024-02-05 Thread Ralph Goers
On 2024/02/05 15:17:29 Volkan Yazıcı wrote: > > AFAIK, nested logging is not a documented feature. Yet one can find several > tickets people has filed issues that were fixed by us. Hence, it is safe to > conclude that it is used. You are correct that it is not documented. Nor should it be. As