Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I am not able to follow: 88 LoC with ad-hoc exclusions . > Maven Assembly Plugin has reproducible builds. :-) You got me there. `git ls-tree | zip` requires an extra l

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi Volkan, On Tue, 2 May 2023 at 22:22, Volkan Yazıcı wrote: > Regarding `maven-assembly-plugin`... I simply don't get the motivation > behind replacing `git ls-files | zip` with hundreds of lines of XML > containing ad-hoc include/exclude statements in a module that needs to be > excluded in var

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

What is the thing exactly cluttering here? It is as transparent as it can possibly get. Regarding `maven-assembly-plugin`... I simply don't get the motivation behind replacing `git ls-files | zip` with hundreds of lines of XML containing ad-hoc include/exclude statements in a module that needs to

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Uh? It should NOT contain an exact copy of a git repository, what do I need a ".github" folder for in order to build the project? I don't, it just clutter things up for no good reason. None of the Apache projects I've seen do this. It sounds like a convenience because it's easy as opposed to using

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I completely disagree. Generated ZIP archive contains _an exact copy_ of the repository snapshot used to generate the release. (In a nutshell, it is `git ls-files | zip` output.) Contrast this with Log4j, which bundles everything out there using the provided configuration composed of dozens of lin

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I agree that we should share the link to the `KEYS` file, granted that we also share the signing key's public ID. As a side note, the shared link is not a random one; it is the one used by Nexus to verify the signatures. (Yes, I am aware that Nexus is not recognized as an official distribution mec

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

I don’t see release notes or a download link at that site. Personally, I think the side nav link should be under a new “related projects” heading rather than making it appear that it is a component of Log4j2 itself. FWIW, I am leaving this under the vote thread since it sounds like you are goi

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

+1 Tests the src zip, asc and SHA file OK despite the SHA file being broken as Ralph noted (there should not be a target folder in the name). mvn clean verify OK with: Apache Maven 3.9.1 (2e178502fcdbffc201671fb2537d0cb4b4cc58f8) Maven home: C:\java\apache-maven-3.9.1 Java version: 17.0.7, vend

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

HI Ralph: Nitpicking: I'm pretty sure you're supposed to test the src zip, not the repo. In theory these two are different because the zip should not contain extra non-source junk like the .github folder. Gary On 2023/05/02 04:29:22 Ralph Goers wrote: > +1 > > I checked out the tag and built t

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Another needed clean-up (not a blocker): The zip file has all sorts of git junk: a .github folder, a .gitignore file, and a .mvn folder (I certainly don't want extra maven junk either but that's just me)? There should only _sources_, not a snapshot of all files in the github repo. For example, s

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Note: > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index A random link on the internet is irrelevant, what matters is what is in our KEYS file at: https://downloads.apache.org/logging/KEYS Gary On 2023/05/01 19:09:3

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi, On Mon, 1 May 2023 at 21:09, Piotr P. Karwasz wrote: > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide > location information without reflection. There is a small but pesky restriction in the Maven plugin: there is no includes/excludes setting. While not a problem for the gen

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

Hi, On Mon, 1 May 2023 at 21:09, Piotr P. Karwasz wrote: > Source repository: https://github.com/apache/logging-log4j-transform > Tag: rel/0.1.0-rc2 > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae > Artifacts: > https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0 > Nexus repo

Re: [VOTE] Release Apache Log4j Transformation Tools 0.1.0

+1 I checked out the tag and built the transformer and then ran it against one of my projects at work and verified it generated some Log4j2Cache classes. I verified the signature. I verified the checksum. While it is a good checksum the file name included in the .sha512 file is target/apache-lo