Re: Problems creating custom appender using JPMS service in 3.0.0-beta3

2024-12-04 Thread Ralph Goers
Some huge points are being overlooked in this discussion. 1. A Plugin is NOT a Java service. You cannot manually create the META-INF/services entry for your plugin as the plugin system won’t recognize it. 2. A Plugin service is a collection of plugins. This is intentional as loading all the plug

Re: Problems creating custom appender using JPMS service in 3.0.0-beta3

2024-12-04 Thread Gary Gregory
Well my thing only worked after I added it. And people can only copy what we do... Gary On Wed, Dec 4, 2024, 12:31 PM Matt Sicker wrote: > That’s specific to our build, Gary, in order to avoid running the > processor on modules that don’t need it. Typical users would probably only > have a sing

Re: Problems creating custom appender using JPMS service in 3.0.0-beta3

2024-12-04 Thread Matt Sicker
That’s specific to our build, Gary, in order to avoid running the processor on modules that don’t need it. Typical users would probably only have a single module with custom Log4j plugins. > On Dec 4, 2024, at 09:19, Gary Gregory wrote: > > I had to put some mysterious dot file in the root of

Re: Problems creating custom appender using JPMS service in 3.0.0-beta3

2024-12-04 Thread Gary Gregory
I had to put some mysterious dot file in the root of my Maven module to get my plugin to work. The only way I found this is by comparison with another module but not all modules have this file. Gary On Wed, Dec 4, 2024, 8:16 AM Volkan Yazıcı wrote: > I agree with Pavel that users should only be

Re: Problems creating custom appender using JPMS service in 3.0.0-beta3

2024-12-04 Thread Volkan Yazıcı
I agree with Pavel that users should only be required to 1. Provide the interface implementation 2. Create the associated `META-INF/services` file entry 3. [For Java 9 and above] Update their `module-info.java` accordingly Anything more than this is non-idiomatic. Telling users "but proc

Re: Problems creating custom appender using JPMS service in 3.0.0-beta3

2024-12-02 Thread Matt Sicker
Yes, it could make sense to replace PluginService stuff with things based on CFIPP. I developed the DI system somewhat independently from the plugin system because of the need to support components from the API, and the plugin system was reimplemented in terms of the DI system, so any simplifica

Re: Problems creating custom appender using JPMS service in 3.0.0-beta3

2024-11-29 Thread Piotr P. Karwasz
Hi Pavel, [NOTE: I am cross-posting this to `dev@logging`, since I believe it is more appropriate there] On 29.11.2024 10:26, PavelTurk wrote: In the world of JPMS, there’s a service, we implement it, and we add it. I haven’t heard of a service + PROCESSOR that needs to be used. Can you poin