Yes, that’s a good idea.
On Fri, Jan 17, 2020 at 04:44 Volkan Yazıcı wrote:
> Shall we remove the @deprecated entry in javadocs until the design is
> finalized and merged to master?
>
> On Thu, Jan 16, 2020 at 5:49 PM Matt Sicker wrote:
> >
> > Yeah, I'm still working on some fundamental change
Shall we remove the @deprecated entry in javadocs until the design is
finalized and merged to master?
On Thu, Jan 16, 2020 at 5:49 PM Matt Sicker wrote:
>
> Yeah, I'm still working on some fundamental changes to annotations,
> but it will still be backward compatible with what already worked
> be
I will note that theoretically, there may be differences in how
default values are handled if you use @PluginAttribute on a builder
attribute, but I think it'd only be the case if you specify a default
value in both the annotation and the field.
On Thu, 16 Jan 2020 at 10:48, Matt Sicker wrote:
>
Yeah, I'm still working on some fundamental changes to annotations,
but it will still be backward compatible with what already worked
before. You can use @PluginAttribute directly on either the fields of
the builder class or the setter methods (I forget if that's supported
in 2.x, but it works in m
I think Matt is still figuring out how he wants to change things. I imagine he
will document it after he has finished.
These changes should only be in master.
Ralph
> On Jan 16, 2020, at 8:57 AM, Carter Kozak wrote:
>
> Perhaps we need to update our docs/javadoc.
>
> -ck
>
>> On Jan 16, 202
Perhaps we need to update our docs/javadoc.
-ck
> On Jan 16, 2020, at 10:54 AM, Ralph Goers wrote:
>
> Builders haven’t gone away, if that is what you are thinking. I think all
> Matt did was make it so you could use @PluginAttribute wherever you would
> have used @PluginBuilderAttribute. I
Builders haven’t gone away, if that is what you are thinking. I think all Matt
did was make it so you could use @PluginAttribute wherever you would have used
@PluginBuilderAttribute. I am not really sure why. Nothing else should have
changed.
Ralph
> On Jan 16, 2020, at 8:35 AM, Volkan Yazıcı
Hello,
Started working on replacing JsonLayout with LogstashLayout. I have
noticed that @PluginAttributeBuilder is deprecated in favor of
@PluginAttribute. I am not equipped with the sufficient background on
this decision's justification, but what I can tell is I find
@PluginAttribute unpleasant t
