Re: Opportunities for cohesion improvement and refatoring.

2017-07-19 Thread Matt Sicker
I think AbstractConfiguration (along with XmlConfiguration and JsonConfiguration) seems like a good candidate. I've had it on a list of mine to try to refactor one day. As Ralph said, Logger is pretty off limits being a public API (the duplication is somewhat intentional for user convenience and op

Re: Opportunities for cohesion improvement and refatoring.

2017-07-19 Thread Apache
Logger is the main interface for logging. I am not sure why we would want to refactor it. It is also part of the public API so any changes must be backward compatible. The LogEvent is the class that captures the logging data. It has several variations as you can see. Although it is not part of

Re: Opportunities for cohesion improvement and refatoring.

2017-07-19 Thread Dominik Psenner
Hi, You should do atomar modifications in single commits and file one pull request for a sensible set of patches. Remember to also write sensible commit messages that explain what is done and why it is done. This allows easy and fast code reviews. Github is great for doing all but the actual codin

Opportunities for cohesion improvement and refatoring.

2017-07-19 Thread João Paulo Lemes Machado
Hello everyone. My name is João Paulo, I am a graduate student the Federal University of Uberlandia, Brazil. I was analyzing the modularization of some classes of log4j, and I identified some opportunities for cohesion improvement in the following classes: Logger DefaultConfigurationBuilder Con