Re: New time classes and Java 8

2018-01-27 Thread Gary Gregory
On Sat, Jan 27, 2018 at 4:28 PM, Remko Popma wrote: > Well, we can’t use java.time.Instant in LogEvent and still be garbage > free. So that’s a bigger discussion. > > You have reviewed the code, so I hope you agree, but I think our new time > code is pretty clean. One could argue that the transla

Re: New time classes and Java 8

2018-01-27 Thread Remko Popma
Well, we can’t use java.time.Instant in LogEvent and still be garbage free. So that’s a bigger discussion. You have reviewed the code, so I hope you agree, but I think our new time code is pretty clean. One could argue that the translation from epochSeconds to epochMillis is duplication from j

New time classes and Java 8

2018-01-27 Thread Gary Gregory
Hi Remko: Curious: How much bending over backward are we doing with this new time code by _not_ using Java 8? Gary