ing to merge the changes for LOG4J2-3472 into master, but I have
> trouble building the master branch... (and I don't think it is because of
> my changes)
>
> Am I missing something?
>
> My environment
> -
> C:\Users\remko\IdeaProjects\logging-
Hello Jason,
On Thu, 21 Apr 2022 at 20:03, Jason Pyeron wrote:
> git worktrees.
>
Nice feature, I didn't know about it.
Unfortunately JGit's support for worktrees is in its infancy (
https://git.eclipse.org/r/c/jgit/jgit/+/163940), which means no worktrees
support in Eclipse and probably othe
> -Original Message-
> From: Matt Sicker
> Sent: Thursday, April 21, 2022 1:31 PM
> To: Apache Logging Developers List
> Subject: Re: does the master branch compile?
>
> You've only got two copies of the git checkout? If I knew of better
> ways of keeping wo
You've only got two copies of the git checkout? If I knew of better
ways of keeping works in progress stored in Git other than `git
stash`, I wouldn't have so many local copies myself.
On Thu, Apr 21, 2022 at 10:15 AM Gary Gregory wrote:
>
> I keep two repositories, one for master, one for releas
I keep two repositories, one for master, one for release-2.x, because of
this kind of sillinesss.
Gary
On Thu, Apr 21, 2022, 08:04 Remko Popma wrote:
> Thank you Piotr!
>
> Understood now.
> Too bad that switching branches from 2.x to master leaves the invalid
> source code under log4j-api/src/
Thank you Piotr!
Understood now.
Too bad that switching branches from 2.x to master leaves the invalid source
code under log4j-api/src/test (and mvn clean also doesn’t remove it).
I’ll just have to remember that I guess.
:-)
Thanks again for the quick reply.
> On Apr 21, 2022, at 20:52, Pio
Hello Remko,
On Thu, 21 Apr 2022 at 13:14, Remko Popma wrote:
> Warnings look like this:
> [WARNING]
>
> C:\Users\remko\IdeaProjects\logging-log4j2\log4j-api\src\test\java\org\apache\logging\log4j\LogManagerTest.java:[52,5]
> [exports] class Test in module is not exported
>
In `master` there i
Hi all,
I am trying to merge the changes for LOG4J2-3472 into master, but I have
trouble building the master branch... (and I don't think it is because of
my changes)
Am I missing something?
My environment
-
C:\Users\remko\IdeaProjects\logging-log4j2>mvn --versio
Gary,
To be clear, you are proposing that we create the same log4j-api-test and
log4j-core-test modules that exist in master? If you want to do that work I
won’t object.
But I myself would prefer to focus on master at this point as much as possible
so we
can get 3.0 out in a reasonable time f
On Mon, Jan 3, 2022 at 7:30 AM Volkan Yazıcı wrote:
> Fantastic work Ralph! Please see my comments below:
>
> On Tue, Dec 28, 2021 at 9:39 AM Ralph Goers
> wrote:
> > Most of the components that were generating test jars have been split
> into two modules - the main component,
> > which only bui
> On Jan 3, 2022, at 1:47 PM, Volkan Yazıcı wrote:
>>
>
> Sorry, I think I have been a victim of my own incorrect wording. I rather
> wanted to suggest "placing all tests _exposed as test JARs_ to their own
> modules". I think we both agree on this. Please, correct me if I am wrong.
There is
On Mon, Jan 3, 2022 at 5:28 PM Ralph Goers
wrote:
>
>
> > On Jan 3, 2022, at 5:30 AM, Volkan Yazıcı wrote:
> >
> > Fantastic work Ralph! Please see my comments below:
> >
> > On Tue, Dec 28, 2021 at 9:39 AM Ralph Goers
> > wrote:
> >> Most of the components that were generating test jars have b
There’s already a ticket for JUnit 5 I filed a while ago.
—
Matt Sicker
> On Jan 3, 2022, at 10:28, Ralph Goers wrote:
>
>
>
>> On Jan 3, 2022, at 5:30 AM, Volkan Yazıcı wrote:
>>
>> Fantastic work Ralph! Please see my comments below:
>>
>>> On Tue, Dec 28, 2021 at 9:39 AM Ralph Goers
>>
> On Jan 3, 2022, at 5:30 AM, Volkan Yazıcı wrote:
>
> Fantastic work Ralph! Please see my comments below:
>
> On Tue, Dec 28, 2021 at 9:39 AM Ralph Goers
> wrote:
>> Most of the components that were generating test jars have been split
> into two modules - the main component,
>> which only
Fantastic work Ralph! Please see my comments below:
On Tue, Dec 28, 2021 at 9:39 AM Ralph Goers
wrote:
> Most of the components that were generating test jars have been split
into two modules - the main component,
> which only builds the jar, and a -test component that builds a -test jar
and then
I have “fixed” the master branch build.
Most of the components that were generating test jars have been split into two
modules - the main component,
which only builds the jar, and a -test component that builds a -test jar and
then runs the unit tests. But there are
still quirks:
1. log4j
I must have gotten side tracked and not ported to master. Sorry about that.
Please go ahead, on planes today...
Gary
On Mon, Sep 13, 2021, 13:59 Carter Kozak wrote:
> In cherry-picking a change from release-2.x to master I ran into some
> conflicts because
> https://github.com/apache/logging-lo
In cherry-picking a change from release-2.x to master I ran into some conflicts
because
https://github.com/apache/logging-log4j2/commit/97ec707d69280ef57aed8fd5831dc4f3a75f7715
was merged to the release branch, but never ported to master. Gary, do you
recall if this was intentional? If not I'd
;
> Ralph
>
> > On Jul 10, 2021, at 1:04 PM, Gary Gregory
> wrote:
> >
> > I'm exasperated by our build on the master branch; JPMS feels like the
> > iceberg that will sink Java.
> >
> > I can build release-2.x nicely with 'mvn clean package&#
are running with Java 8.
> >
> > Ralph
> >
> > > On Jul 10, 2021, at 1:04 PM, Gary Gregory
> > wrote:
> > >
> > > I'm exasperated by our build on the master branch; JPMS feels like the
> > > iceberg that will sink Java.
>
are running with Java 8.
>
> Ralph
>
> > On Jul 10, 2021, at 1:04 PM, Gary Gregory
> wrote:
> >
> > I'm exasperated by our build on the master branch; JPMS feels like the
> > iceberg that will sink Java.
> >
> > I can build release-2.x nice
Master no longer needs a toolchain file. It only uses Java 11. It sorta sounds
like you are running with Java 8.
Ralph
> On Jul 10, 2021, at 1:04 PM, Gary Gregory wrote:
>
> I'm exasperated by our build on the master branch; JPMS feels like the
> iceberg that will sink Java.
I'm exasperated by our build on the master branch; JPMS feels like the
iceberg that will sink Java.
I can build release-2.x nicely with 'mvn clean package'
If I do that on master I get:
...
[INFO] Reactor Summary for Apache Log4j 2 3.0.0-SNAPSHOT:
[INFO]
[INFO]
That is really nice of you to investigate this further Ralph, really much
appreciated! I think your findings are aligned with my earlier proposal,
which in turn will hopefully significantly reduce the JPMS hazard we have
in "master". Please take your time and go ahead with this. I am looking
forwar
I have asked on the Maven dev list about the process of building modules that
contain test jars. It seems the recommended
approach for test jars in general has changed and it is now recommended to
build them in their own project. This means
log4j-core would only contain the main source and tha
- which is another reason why the code had to be
> > >> compiled separately from the module-info.java file. I’m really curious -
> > >> why do you run mvn twice and just not skip tests the first time?
> > >>>
> > >>> Ralph
> > >&
rom the module-info.java file. I’m really curious -
> >> why do you run mvn twice and just not skip tests the first time?
> >>>
> >>> Ralph
> >>>
> >>>> On Apr 5, 2021, at 2:18 PM, mattsic...@apache.org wrote:
> >>>>
> &g
ce and just not skip tests the first time?
>>>
>>> Ralph
>>>
>>>> On Apr 5, 2021, at 2:18 PM, mattsic...@apache.org wrote:
>>>>
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>>
>>>> mat
er pushed a commit to branch master
> >> in repository https://gitbox.apache.org/repos/asf/logging-pipelines.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/master by this push:
> >>new 10333f7 Use Java 11 for master branch
> >
.
>>
>> mattsicker pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/logging-pipelines.git
>>
>>
>> The following commit(s) were added to refs/heads/master by this push:
>>new 10333f7 Use Java 11 for master branch
>&
ASF dual-hosted git repository.
>
> mattsicker pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/logging-pipelines.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 10333f7 Use Java 11 for master
>> else also breaks the compilation. Though I did not further dig this
>> down. Just don't do it.
>>
>> On Wed, Mar 4, 2020 at 12:51 PM Volkan Yazıcı
>> wrote:
>>>
>>> Hello,
>>>
>>> While developing it is really difficult
maven-jar-plugin configuration to something
> else also breaks the compilation. Though I did not further dig this
> down. Just don't do it.
>
> On Wed, Mar 4, 2020 at 12:51 PM Volkan Yazıcı
> wrote:
> >
> > Hello,
> >
> > While developing it is really diffic
rote:
>
> Hello,
>
> While developing it is really difficult to keep up with the master
> branch, it continuously gets broken. master and release-2.x diverge a
> lot as well, hence I am sitting on the fence for whether I should base
> my changes on master or release-2.x. This is m
>>>
>>>>> I still get the very same error. I see that Jenkins is still failing,
>>>>> though Travis has recovered yesterday after a change of yours. What
>>>>> might I be missing? How can I further debug the problem?
>>>>>
>>
e/logging
>>>> $ ./mvnw package -Dmaven.test.skip=true
>>>>
>>>> I still get the very same error. I see that Jenkins is still failing,
>>>> though Travis has recovered yesterday after a change of yours. What
>>>> might I be missing? How can I furth
; though Travis has recovered yesterday after a change of yours. What
> > > might I be missing? How can I further debug the problem?
> > >
> > > On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers
> > > wrote:
> > > >
> > > > My typical developmen
gt; wrote:
> > >
> > > My typical development follow 1 of 2 paths.
> > >
> > > 1. I am doing a patch or new feature targeted at the 2.x release train. I
> > > do my initial development on the release-2.x branch. Once it is fully
> > > teste
er debug the problem?
>
> On Wed, Mar 4, 2020 at 5:11 PM Ralph Goers wrote:
> >
> > My typical development follow 1 of 2 paths.
> >
> > 1. I am doing a patch or new feature targeted at the 2.x release train. I
> > do my initial development on the release-2.x bran
> my initial development on the release-2.x branch. Once it is fully tested I
> cherry-pick it (when possible) to the master branch. If I can’t cherry-pick
> it I manually copy the changes. For both release-2.x and master I ALWAYS run
> full builds before committing. I only run the bui
My typical development follow 1 of 2 paths.
1. I am doing a patch or new feature targeted at the 2.x release train. I do my
initial development on the release-2.x branch. Once it is fully tested I
cherry-pick it (when possible) to the master branch. If I can’t cherry-pick it
I manually copy
Hello,
While developing it is really difficult to keep up with the master
branch, it continuously gets broken. master and release-2.x diverge a
lot as well, hence I am sitting on the fence for whether I should base
my changes on master or release-2.x. This is my current state:
$ git remote -v
Please checkout the latest from master. 3.0 is still under development and
changes are being made to clean things up and make the modules conform to the
Java module system. It now uses RevAPI to track changes so it compares against
the last 2.x release. The errors you are seeing are from it ide
I'm stuck with below error, has anyone seen this error?
any quick solution?
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 01:08 min
[INFO] Finished at: 2019-03-02T17:44:07-06:00
[INFO] Final Memory: 184M/1642M
[INFO]
-
44 matches
Mail list logo
