Re: Log4j master branch

2021-07-11 Thread Volkan Yazıcı
I would have expected the build to fail (via maven-enforcer-plugin?) when the build is run with a JDK that is not 8. On Sun, Jul 11, 2021 at 9:30 AM Ralph Goers wrote: > Master no longer needs a toolchain file. It only uses Java 11. It sorta > sounds like you are running with Java 8. > > Ralph >

Re: Log4j master branch

2021-07-11 Thread Matt Sicker
I’ve been making good progress on the bean stuff. Hopefully untangling the annotation processor from the annotations and the service class will help IDE compatibility. As it is, I’ve been running tests from the command line in individual modules as suggested by Ralph. While not ideal, it’s turned o

Re: Log4j master branch

2021-07-11 Thread Gary Gregory
Ah, yes, thank you Ralph, and my mistake: I was not building with Java 11. Eclipse is still messed up but that's a different story... Gary On Sun, Jul 11, 2021 at 3:30 AM Ralph Goers wrote: > Master no longer needs a toolchain file. It only uses Java 11. It sorta > sounds like you are running wi

Re: Log4j master branch

2021-07-11 Thread Ralph Goers
Master no longer needs a toolchain file. It only uses Java 11. It sorta sounds like you are running with Java 8. Ralph > On Jul 10, 2021, at 1:04 PM, Gary Gregory wrote: > > I'm exasperated by our build on the master branch; JPMS feels like the > iceberg that will sink Java. > > I can build r

Re: Log4j master branch

2021-07-10 Thread Gary Gregory
I'm exasperated by our build on the master branch; JPMS feels like the iceberg that will sink Java. I can build release-2.x nicely with 'mvn clean package' If I do that on master I get: ... [INFO] Reactor Summary for Apache Log4j 2 3.0.0-SNAPSHOT: [INFO] [INFO] Apache Log4j 2

Re: Log4j master branch

2021-06-23 Thread Volkan Yazıcı
That is really nice of you to investigate this further Ralph, really much appreciated! I think your findings are aligned with my earlier proposal, which in turn will hopefully significantly reduce the JPMS hazard we have in "master". Please take your time and go ahead with this. I am looking forwar

Log4j master branch

2021-06-22 Thread Ralph Goers
I have asked on the Maven dev list about the process of building modules that contain test jars. It seems the recommended approach for test jars in general has changed and it is now recommended to build them in their own project. This means log4j-core would only contain the main source and tha