Re: Log4j 2.x RedisAppender

I think this should go into a new maven module "log4j-redis" since it has a specific external dependency (Jedis). We will most likely split up the NoSQL module and we don't want to add anything new to it. "NoSQL" is not really a useful abstraction within the context of Log4j. On Sat, May 6, 2017

Re: Log4j 2.x RedisAppender

Yeah, as mentioned on the ticket, we're working on splitting up that module as it is. On 6 May 2017 at 15:00, Gary Gregory wrote: > On Sat, May 6, 2017 at 12:48 PM, Volkan Yazıcı > wrote: > > > I was thinking of log4j-nosql Maven module. > > Cassandra, CouchDb, MongoDb appenders also exist with

Re: Log4j 2.x RedisAppender

On Sat, May 6, 2017 at 12:48 PM, Volkan Yazıcı wrote: > I was thinking of log4j-nosql Maven module. > Cassandra, CouchDb, MongoDb appenders also exist within the same Maven > module. > Are you sure that I need to create a separate Maven module just for the > Redis appender? > Let's see what othe

Re: Log4j 2.x RedisAppender

Created the following JIRA ticket: LOG4J2-1897 . On Sat, May 6, 2017 at 9:06 PM, Volkan Yazıcı wrote: > Appreciated the detailed prompt reply, thanks Matt! > >1. Then I will go with Jedis without any Maven shade plugin hacks. >2. BurstFi

Re: Log4j 2.x RedisAppender

I was thinking of log4j-nosql Maven module. Cassandra, CouchDb, MongoDb appenders also exist within the same Maven module. Are you sure that I need to create a separate Maven module just for the Redis appender? On Sat, May 6, 2017 at 9:40 PM, Gary Gregory wrote: > Hi Volkan, > > Thank you for co

Re: Log4j 2.x RedisAppender

Hi Volkan, Thank you for contributing to Log4j. This should do in a new Maven module IMO. Gary On Sat, May 6, 2017 at 11:30 AM, Volkan Yazıcı wrote: > Hello, > > To the best of my knowledge, there is no Redis support in Log4j 2.x NoSQL > Appenders. (Please correct if I'm wrong.) I want to cre

Re: Log4j 2.x RedisAppender

The AbstractIpcAppender thing is more of a general issue that doesn't really need to be solved at this time. It's just a thought I had while thinking that SQL and NoSQL are not the only style appenders that can benefit. This could eventually be useful in refactoring the MOM appenders (JMS, Kafka, Z

Re: Log4j 2.x RedisAppender

Appreciated the detailed prompt reply, thanks Matt! 1. Then I will go with Jedis without any Maven shade plugin hacks. 2. BurstFilter covers rate limiting. 3. AsyncLogger covers consumer-producer rate mismatch regulation. 4. I've checked the CassandraAppender. It leverages the multiple

Re: Log4j 2.x RedisAppender

Instead of forming a new thread to point this out, I'll note it here: the AbstractDatabaseAppender classes may be refactorable or renamable into a sort of AbstractIpcAppender instead as another major category of appenders. Might be worth examining, though it's something we'd help in structuring at

Re: Log4j 2.x RedisAppender

Oh, I also forgot to mention that regarding batching of log messages, several appenders already follow a similar pattern, so you may find some reusable code there, especially if you're modeling this from the NoSqlAppender/Manager abstract classes as well as the AbstractDatabaseAppender/Manager clas

Re: Log4j 2.x RedisAppender

First of all, we love contributions, and this one sounds interesting, too. 1. I don't have experience with Redis (I've used other distributed memory caches and data grid frameworks, though), so I don't have an opinion on which library to use for it. 2. As for the RateLimiter class, I'll note that

Log4j 2.x RedisAppender

Hello, To the best of my knowledge, there is no Redis support in Log4j 2.x NoSQL Appenders. (Please correct if I'm wrong.) I want to create a JIRA ticket and start working on a RedisAppender. Though I do have some questions and will appreciate your feedback. 1. I plan to use Jedis