Re: [Discuss] Log4j 2.12.1 release

2019-08-08 Thread Remko Popma
No problem for me either. I am unable to verify this time around, but we have enough votes for the release. Thank you for RM-ing! Remko > On Aug 9, 2019, at 3:33, Gary Gregory wrote: > > +1 fine with me. Thank you for RM'ing. > > Gary > >> On Thu, Aug 8, 2019, 13:19 Ralph Goers wrote: >>

Re: [Discuss] Log4j 2.12.1 release

2019-08-08 Thread Gary Gregory
+1 fine with me. Thank you for RM'ing. Gary On Thu, Aug 8, 2019, 13:19 Ralph Goers wrote: > Normally release votes are open for 72hrs. However, I will be going out of > town tomorrow and not returning until Sunday. Unless there are objections > I would like to close the vote early, in about 10

[Discuss] Log4j 2.12.1 release

2019-08-08 Thread Ralph Goers
Normally release votes are open for 72hrs. However, I will be going out of town tomorrow and not returning until Sunday. Unless there are objections I would like to close the vote early, in about 10 hours from now, which is only a 48 hour window. Otherwise I won’t be able to finish the release

Re: Log4j 2.12.1 release

2019-08-06 Thread Gary Gregory
On Tue, Aug 6, 2019 at 12:11 PM Matt Sicker wrote: > If the batch size is set to 1 (or 0), shouldn't that just disable > batching entirely? I don't see the point of creating and executing > batched statements if you only use it once. > Good point, so there is also a bug in the JDBC Appender wher

Re: Log4j 2.12.1 release

2019-08-06 Thread Matt Sicker
If the batch size is set to 1 (or 0), shouldn't that just disable batching entirely? I don't see the point of creating and executing batched statements if you only use it once. On Tue, 6 Aug 2019 at 09:40, Gary Gregory wrote: > > On Tue, Aug 6, 2019 at 10:39 AM Gary Gregory wrote: > > > On Mon,

Re: Log4j 2.12.1 release

2019-08-06 Thread Gary Gregory
On Tue, Aug 6, 2019 at 10:39 AM Gary Gregory wrote: > On Mon, Aug 5, 2019 at 11:00 AM Gary Gregory > wrote: > >> FYI: I plan on looking at >> https://issues.apache.org/jira/browse/LOG4J2-2667 today/tonight. >> > > Please see my comments in the Jira above WRT batching. The upshot is that > to wor

Re: Log4j 2.12.1 release

2019-08-06 Thread Gary Gregory
On Mon, Aug 5, 2019 at 11:00 AM Gary Gregory wrote: > FYI: I plan on looking at > https://issues.apache.org/jira/browse/LOG4J2-2667 today/tonight. > Please see my comments in the Jira above WRT batching. The upshot is that to workaround buggy JDBC drivers (My tests show no issues using H2, MySQL

Re: Log4j 2.12.1 release

2019-08-05 Thread Gary Gregory
FYI: I plan on looking at https://issues.apache.org/jira/browse/LOG4J2-2667 today/tonight. Gary On Mon, Aug 5, 2019 at 10:48 AM Ralph Goers wrote: > I fixed the performance issue but I keep getting a test failure in > SocketReconnectTest on my build machine. I don’t see it on my newer MacBook >

Re: Log4j 2.12.1 release

2019-08-05 Thread Ralph Goers
I fixed the performance issue but I keep getting a test failure in SocketReconnectTest on my build machine. I don’t see it on my newer MacBook Pro. Ralph > On Aug 4, 2019, at 3:14 PM, Ralph Goers wrote: > > I am running a compile before performing the release and am seeing > significant negat

Re: Log4j 2.12.1 release

2019-08-04 Thread Ralph Goers
I am running a compile before performing the release and am seeing significant negative performance changes in the core integration tests module. I am going to have to investigate those before performing a release. Ralph > On Aug 4, 2019, at 8:26 AM, Matt Sicker wrote: > > Sounds like a plan!

Re: Log4j 2.12.1 release

2019-08-04 Thread Matt Sicker
Sounds like a plan! On Sun, Aug 4, 2019 at 10:13, Carter Kozak wrote: > Thanks Ralph! > > -ck > > On Sun, Aug 4, 2019, at 06:56, Gary Gregory wrote: > > Sounds good. > > > > Gary > > > > On Sun, Aug 4, 2019, 03:11 Ralph Goers > wrote: > > > > > We have a few commits on the release-2.x branch th

Re: Log4j 2.12.1 release

2019-08-04 Thread Carter Kozak
Thanks Ralph! -ck On Sun, Aug 4, 2019, at 06:56, Gary Gregory wrote: > Sounds good. > > Gary > > On Sun, Aug 4, 2019, 03:11 Ralph Goers wrote: > > > We have a few commits on the release-2.x branch that are important that > > user’s who still use Java 7 would want. So I am planning on performi

Re: Log4j 2.12.1 release

2019-08-04 Thread Gary Gregory
Sounds good. Gary On Sun, Aug 4, 2019, 03:11 Ralph Goers wrote: > We have a few commits on the release-2.x branch that are important that > user’s who still use Java 7 would want. So I am planning on performing a > 2.12.1 release later today. I will then make the changes to the pom to > target

Log4j 2.12.1 release

2019-08-04 Thread Ralph Goers
We have a few commits on the release-2.x branch that are important that user’s who still use Java 7 would want. So I am planning on performing a 2.12.1 release later today. I will then make the changes to the pom to target it to Java 8 and start bringing in some Java 8 specific code from master.