Jochen,
Hamcrest 1.3 used to be pulled in by JUnit, but it isn't pulled in by
JUnit5. When I converted all the tests to JUnit5 syntax and dropped the
JUnit4 bridge then I needed to pull in hamcrest explicitly. I went with 1.3
to match the rest of the code base.
Tim
On Mon, Feb 1, 2021 at 12:59
On Mon, Jan 25, 2021 at 10:06 PM Tim Perry wrote:
>
> Is it okay to import hamcrest to use in the tests?
>
>
> org.hamcrest
> hamcrest
> 2.2
> test
>
Isn't that pulled in automatically via junit? See, for example, the
Pom in https://search.maven.org/artifact/junit/junit/4.13.1/j
ts / pull request to JIRA LOG4J2-2624 and
> LOG4J2-1606?
>
>
>>> On Thu, 28 Jan 2021 at 13:47, Tim Perry wrote:
>>>>
>>>> I submitted pull request 463 for this work.
>>>> https://github.com/apache/logging-log4j2/pull/463
>>>>
&
How do I link the commits / pull request to JIRA LOG4J2-2624 and
LOG4J2-1606?
>> On Thu, 28 Jan 2021 at 13:47, Tim Perry wrote:
> >>
> >> I submitted pull request 463 for this work.
> >> https://github.com/apache/logging-log4j2/pull/463
> >>
> >
>>>>> fundamentally change the lifecycle hooks for web modules
>>>> and
>>>>>> each
>>>>>>>>> class
>>>>>>>>>>>> loader will still have its own independent log4j config.
>>>> The
>&
is
> >> > > unacceptable,
> >> > > > >> I'm
> >> > > > >> > > > happy to revisit the code and come up with another
> >> solution.
> >> > > Here
> >> > > > >> are the
> >> > > > >> > &
;> > > > >> > >
>> > > > >>
>> > >
>> https://github.com/perry2of5/logging-log4j2/commit/56455af53920d69ff7a49a63c5bbf38773069e8d
>> > > > >> > > >
>> > > > >> > > > I'd really like to
; there
> > > are
> > > > >> more
> > > > >> > > > important things for the log4j team to work on and that
> there
> > > is no
> > > > >> > > > interest from the log4j committers to make these changes, I
&g
t; > > that. However, I think these changes would be welcomed by some
> > log4j
> > > >> > > users
> > > >> > > > and I hope one of the log4j committers will work with me on
> > solving
> > > >> these
> > > >> > > > issues.
> Thanks,
> > >> > > > Tim
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > On Sun, Jan 24, 2021 at 6:29 PM Matt Sicker
> > >>
> > > >
> >> > > >
> >> > > > On Sun, Jan 24, 2021 at 6:29 PM Matt Sicker
> >> wrote:
> >> > > >
> >> > > > > I'm not sure how much any of the devs here use the log4j-web
> >> module
> >> >
; > > > > I'm not sure how much any of the devs here use the log4j-web
>> module
>> > > > > anymore (seems more common to use fat jars or one app per servlet
>> > > > > container instance at least), so it's hard to say a
container instance at least), so it's hard to say about any
> > > > > idiosyncrasies. The main purpose of the lifecycle hooks for web
> > > > > modules is to allow each class loader to have its own independent
> > > > > log4j config, though I'm
gt; > log4j config, though I'm not sure how common that deployment pattern
> > > > is anymore. There are alternative strategies such as hooking into the
> > > > server code itself so that logging can shutdown with the server rather
> > > > than the individ
ng can shutdown with the server rather
> > > than the individual applications, but that's a different use case.
> > >
> > > As for design ideas, I think I had initially wanted to refactor the
> > > web context API to mimic how Spring Framework registers itself in the
to mimic how Spring Framework registers itself in the
> > ServletContext, though I never got around to doing that, and now I
> > typically use JVM-global logging configurations instead, so I never
> > revisited that.
> >
> > On Fri, 22 Jan 2021 at 11:53, Tim Perry
to mimic how Spring Framework registers itself in the
> ServletContext, though I never got around to doing that, and now I
> typically use JVM-global logging configurations instead, so I never
> revisited that.
>
> On Fri, 22 Jan 2021 at 11:53, Tim Perry wrote:
> >
> > Hell
isited that.
On Fri, 22 Jan 2021 at 11:53, Tim Perry wrote:
>
> Hello,
>
> I'd like to help fix LOG4J2-2624 and LOG4J2-1606. How can I help?
>
> To me, the challenge is to ensure log4j is initialized the very first time
> the ServletContext is provided to any object d
Hello,
I'd like to help fix LOG4J2-2624 and LOG4J2-1606. How can I help?
To me, the challenge is to ensure log4j is initialized the very first time
the ServletContext is provided to any object during application loading and
startup and to stop log4j during the very last event or execution h
19 matches
Mail list logo
