Re: JsonTemplateLayout for Google Cloud Logging

2021-07-05 Thread Raman Gupta
On Sun, Jul 4, 2021 at 2:59 PM Volkan Yazıcı wrote: > *[My answers are inline.]* > > On Thu, Jul 1, 2021 at 11:48 PM Raman Gupta wrote: > > > > > https://issues.apache.org/jira/browse/LOG4J2-3116 > > https://github.com/apache/logging-log4j2/pull/543 > > > > Thanks! I will check these out momenta

Re: JsonTemplateLayout for Google Cloud Logging

2021-07-04 Thread Volkan Yazıcı
*[My answers are inline.]* On Thu, Jul 1, 2021 at 11:48 PM Raman Gupta wrote: > > https://issues.apache.org/jira/browse/LOG4J2-3116 > https://github.com/apache/logging-log4j2/pull/543 > Thanks! I will check these out momentarily. > One administrative note -- as I am a committer (although thus

Re: JsonTemplateLayout for Google Cloud Logging

2021-07-01 Thread Matt Sicker
As a committer, yes, feel free to use the dev field. The due-to field is used for contributions from outside the project. On Thu, Jul 1, 2021 at 4:48 PM Raman Gupta wrote: > > FYI: > > https://issues.apache.org/jira/browse/LOG4J2-3116 > > https://github.com/apache/logging-log4j2/pull/543 > > One

Re: JsonTemplateLayout for Google Cloud Logging

2021-07-01 Thread Raman Gupta
FYI: https://issues.apache.org/jira/browse/LOG4J2-3116 https://github.com/apache/logging-log4j2/pull/543 One administrative note -- as I am a committer (although thus far I have only committed to the log4j2 kotlin repo) should I do dev="rgupta" instead of adding myself in due-to? Some technical

Re: JsonTemplateLayout for Google Cloud Logging

2021-07-01 Thread Volkan Yazıcı
That is a great idea Raman! Would you mind creating a PR along with a Jira ticket, please? I would appreciate if you can take the following into account: - Target release-2.x branch for the PR - Prefix the PR title with the Jira ticket id - Update json-template-layout.adoc.vm (See the "pr

Re: JsonTemplateLayout for Google Cloud Logging

2021-07-01 Thread Matt Sicker
Looks like a nifty feature! On Wed, Jun 30, 2021 at 5:09 PM Raman Gupta wrote: > > I was thinking about contributing a JsonTemplateLayout for the structured > logging format expected by Google Cloud Logging [1]. > > This is what I've come up with so far: any comments are welcome: > https://gist

JsonTemplateLayout for Google Cloud Logging

2021-06-30 Thread Raman Gupta
I was thinking about contributing a JsonTemplateLayout for the structured logging format expected by Google Cloud Logging [1]. This is what I've come up with so far: any comments are welcome: https://gist.github.com/rocketraman/824ca9527bb8c7226d40db2b4d78efa7. [1] https://cloud.google.com/logg