Re: Failing unit tests in log4j-core

2017-05-18 Thread Mikael Ståldal
I was able to fix this by adding @BeforeClass public static void beforeClass() { System.setProperty("log4j2.is.webapp", "false"); } to the failing tests. However, does this mean that the fix for LOG4J2-1583 does not work when Servlet API is present? See NestedLoggingFromToStringTest. Rem

Re: Failing unit tests in log4j-core

2017-05-18 Thread Mikael Ståldal
I have narrowed down the problem to the presence of Servlet API on classpath. Probably due to that our code check for this and change behaviour. See the Constants class. On May 18, 2017 6:15 PM, "Mikael Ståldal" wrote: > I have narrowed down the problem to the presence of Server > > On May 15, 2

Re: Failing unit tests in log4j-core

2017-05-18 Thread Mikael Ståldal
I have narrowed down the problem to the presence of Server On May 15, 2017 6:34 PM, "Ralph Goers" wrote: > Transitive dependencies are always subordinate to dependencies specified > in the pom so changing the order would never matter. > > What makes you think this has anything to do with depende

Re: Failing unit tests in log4j-core

2017-05-15 Thread Ralph Goers
Transitive dependencies are always subordinate to dependencies specified in the pom so changing the order would never matter. What makes you think this has anything to do with dependency versions? Ralph > On May 15, 2017, at 9:25 AM, Gary Gregory wrote: > > I _was_ worth a try :-( > > On Mon

Re: Failing unit tests in log4j-core

2017-05-15 Thread Gary Gregory
I _was_ worth a try :-( On Mon, May 15, 2017 at 8:30 AM, Mikael Ståldal wrote: > I tried to move it to the very end, it did not help. > > On Mon, May 15, 2017 at 5:12 PM, Gary Gregory > wrote: > > > What if you move that dep to the end? Maybe its transitive deps overrides > > over jars. > > > >

Re: Failing unit tests in log4j-core

2017-05-15 Thread Mikael Ståldal
I tried to move it to the very end, it did not help. On Mon, May 15, 2017 at 5:12 PM, Gary Gregory wrote: > What if you move that dep to the end? Maybe its transitive deps overrides > over jars. > > Gary > > On Mon, May 15, 2017 at 8:10 AM, Mikael Ståldal > > wrote: > > > In branch LOG4J2-1442

Re: Failing unit tests in log4j-core

2017-05-15 Thread Gary Gregory
What if you move that dep to the end? Maybe its transitive deps overrides over jars. Gary On Mon, May 15, 2017 at 8:10 AM, Mikael Ståldal wrote: > In branch LOG4J2-1442 (HttpAppender), some unit tests in log4j-core fail. I > guess that's because I have added this test dependency (which has a lo

Failing unit tests in log4j-core

2017-05-15 Thread Mikael Ståldal
In branch LOG4J2-1442 (HttpAppender), some unit tests in log4j-core fail. I guess that's because I have added this test dependency (which has a lot of transitive dependencies): com.github.tomakehurst wiremock test 2.6.0 Any ideas what may cause these failures? [ERROR] AsyncLoggerConf