Re: Due-to in changes.xml

Agreed. But in those cases the dev field would not be them. Ralph > On Aug 14, 2019, at 8:31 AM, Matt Sicker wrote: > > Just don’t remove any due-to changes from committers from before they > became committers. > > On Wed, Aug 14, 2019 at 00:42, Gary Gregory wrote: > >> Talph, >> >> Feel fr

Re: Due-to in changes.xml

Just don’t remove any due-to changes from committers from before they became committers. On Wed, Aug 14, 2019 at 00:42, Gary Gregory wrote: > Talph, > > Feel free to edit changes.xml as you best see fit. > > Gary > > On Tue, Aug 13, 2019, 22:37 Ralph Goers > wrote: > > > The “By” column is a li

Re: Due-to in changes.xml

Talph, Feel free to edit changes.xml as you best see fit. Gary On Tue, Aug 13, 2019, 22:37 Ralph Goers wrote: > The “By” column is a link to the team list that includes all your > information. If you don’t use your userid then the link won’t index into > the list properly. > > Frankly, putting

Re: Due-to in changes.xml

The “By” column is a link to the team list that includes all your information. If you don’t use your userid then the link won’t index into the list properly. Frankly, putting my name in the due-to column would feel like I would be sending a self congratulatory public thank you note to myself. It

Re: Due-to in changes.xml

As I said, no one with commit privs should appear in the due-to. Ever. They already appear in the by column and in git. It diminishes the thanks we give to contributors to add ourselves, so I would request you please stop doing that, frankly I am not sure why you started as I don’t recall seeing

Re: Due-to in changes.xml

The convention I use is dev is the committer and due-to is the creator of the Jira or PR followed by whomever else touched the code. Gary On Tue, Aug 13, 2019, 20:13 Ralph Goers wrote: > Gary, > > I am wondering why you have recently gotten in the habit of adding > yourself to the due-to field

Re: Due-to in changes.xml

Can the “By” column contain real names instead of usernames? On Tue, Aug 13, 2019 at 22:18, Ralph Goers wrote: > I should also add that the changes report already gives credit to the > committer - see the “By” column at > http://logging.apache.org/log4j/2.x/changes-report.html#a2.12.1 < > http:/

Re: Due-to in changes.xml

I should also add that the changes report already gives credit to the committer - see the “By” column at http://logging.apache.org/log4j/2.x/changes-report.html#a2.12.1 so by adding yourself to the due-to field you are giving you

Due-to in changes.xml

Gary, I am wondering why you have recently gotten in the habit of adding yourself to the due-to field of changes.xml. Historically we have always used that to give credit to non-committers who provide patches or significantly contribute to them. As committers we get credit in the source contro