Sorry for the missing links. Here they are:
[1]
https://github.com/vy/log4j2/blob/json-template-layout/log4j-layout-json-template/src/main/java/org/apache/logging/log4j/layout/json/template/util/JsonReader.java
[2]
https://github.com/vy/log4j2/blob/json-template-layout/log4j-layout-json-template
None of the references were included in the email I see in my Mac Mail client.
Were they included?
Ralph
> On Mar 11, 2020, at 8:19 AM, Volkan Yazıcı wrote:
>
> My comments are inline.
>
> On Wed, Mar 11, 2020 at 4:01 PM Ralph Goers
> wrote:
>> 1. Did you lose functionality by removing the
Take a look at BlockingQueueFactory, too, for making JCTools pluggable.
On Wed, Mar 11, 2020 at 10:21 Volkan Yazıcı wrote:
> No worries, in the mean time I will try to
>
> 1. submit a PR to JCTools
> 2. re-do benchmarks
> 3. implement GcFreeJsonTemplateLayoutTest
>
> On Wed, Mar 11, 2020 at 4:05
No worries, in the mean time I will try to
1. submit a PR to JCTools
2. re-do benchmarks
3. implement GcFreeJsonTemplateLayoutTest
On Wed, Mar 11, 2020 at 4:05 PM Ralph Goers wrote:
>
> Also, I have to apologize that I have not yet reviewed the PR. I promise I
> will but it will take a while wi
My comments are inline.
On Wed, Mar 11, 2020 at 4:01 PM Ralph Goers wrote:
> 1. Did you lose functionality by removing the dependencies?
Except pretty printing, no.
> 2. Did you have to add things like JSON parsing to
> remove the dependencies?
Yes, I have implemented simple JsonReader[1] and
Also, I have to apologize that I have not yet reviewed the PR. I promise I will
but it will take a while with 97 files being modified.
Ralph
> On Mar 11, 2020, at 8:01 AM, Ralph Goers wrote:
>
>
>> On Mar 11, 2020, at 7:09 AM, Volkan Yazıcı wrote:
>>
>> I have finally removed all dependenci
> On Mar 11, 2020, at 7:09 AM, Volkan Yazıcı wrote:
>
> I have finally removed all dependencies of JsonTemplateLayout, except
> for optional JCTools dependency. I have a couple of questions to
> proceed further:
>
> 1. May I move the code in the module to core?
> 2. Shall I remove benchmark re
Hi All:
If this is in master, it should go into a JSON module, existing or new but
not core.
FYI: Dependencies or not, the current JSON layout is in master in
log4j-layout-jackson-json.
One of the complaints I've heard over the years is that log4j-core is too
"big" at 1.6 MB, not to speak of the t
Regarding 2, I don't think we regenerate performance numbers very frequently,
we have older results in the documentation already:
https://logging.apache.org/log4j/2.x/performance.html
On Wed, Mar 11, 2020, at 10:09, Volkan Yazıcı wrote:
> I have finally removed all dependencies of JsonTemplateLa
I have finally removed all dependencies of JsonTemplateLayout, except
for optional JCTools dependency. I have a couple of questions to
proceed further:
1. May I move the code in the module to core?
2. Shall I remove benchmark results in the manual since
it is difficult to keep them up to date?
10 matches
Mail list logo
