Re: Contributing LogstashLayout to Log4j core

2020-02-04 Thread Remko Popma
> but got no replies so far. Any comments? > > [1] https://github.com/apache/logging-log4j2/pull/335/files#r372016555 > > On Tue, Jan 28, 2020 at 9:00 PM Volkan Yazıcı > wrote: > > > > I've just created a PR[1] contributing LogstashLayout to Log4j core. >

Re: Contributing LogstashLayout to Log4j core

2020-02-04 Thread Volkan Yazıcı
28, 2020 at 9:00 PM Volkan Yazıcı wrote: > > I've just created a PR[1] contributing LogstashLayout to Log4j core. > Please see the GitHub link for the feedback/support requests. I will > appreciate a quick review cycle, since I will try my best to invest > quite some time into this during FOSDEM. > > [1] https://github.com/apache/logging-log4j2/pull/335

Re: Contributing LogstashLayout to Log4j core

2020-01-29 Thread Ralph Goers
8? Could be worth >>> exploring. >>> >>> I also noted some clarifications on how plugin dependency injection >>> currently works so you can simplify some of your wrappers if desired. >>> >>> On Tue, 28 Jan 2020 at 13:59, Volkan Yazıcı >> wrote:

Re: Contributing LogstashLayout to Log4j core

2020-01-29 Thread Matt Sicker
t; > On Tue, 28 Jan 2020 at 13:59, Volkan Yazıcı > wrote: > > > > > > I've just created a PR[1] contributing LogstashLayout to Log4j core. > > > Please see the GitHub link for the feedback/support requests. I will > > > appreciate a quick review cycle, since

Re: Contributing LogstashLayout to Log4j core

2020-01-29 Thread Volkan Yazıcı
ome of your wrappers if desired. > > On Tue, 28 Jan 2020 at 13:59, Volkan Yazıcı wrote: > > > > I've just created a PR[1] contributing LogstashLayout to Log4j core. > > Please see the GitHub link for the feedback/support requests. I will > > appreciate a quick rev

Re: Contributing LogstashLayout to Log4j core

2020-01-28 Thread Matt Sicker
t; I also noted some clarifications on how plugin dependency injection > currently works so you can simplify some of your wrappers if desired. > > On Tue, 28 Jan 2020 at 13:59, Volkan Yazıcı wrote: > > > > I've just created a PR[1] contributing LogstashLayout to Log4j cor

Re: Contributing LogstashLayout to Log4j core

2020-01-28 Thread Matt Sicker
. I also noted some clarifications on how plugin dependency injection currently works so you can simplify some of your wrappers if desired. On Tue, 28 Jan 2020 at 13:59, Volkan Yazıcı wrote: > > I've just created a PR[1] contributing LogstashLayout to Log4j core. > Please see the Gi

Contributing LogstashLayout to Log4j core

2020-01-28 Thread Volkan Yazıcı
I've just created a PR[1] contributing LogstashLayout to Log4j core. Please see the GitHub link for the feedback/support requests. I will appreciate a quick review cycle, since I will try my best to invest quite some time into this during FOSDEM. [1] https://github.com/apache/logging-log4j2