Re: Build fails in Master

2022-01-31 Thread Matt Sicker
This: https://github.com/apache/logging-log4j2/blob/5016b9522d58aedffd18def7d8300eec4637e330/log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/PluginAliases.java#L36 https://github.com/apache/logging-log4j2/blob/5016b9522d58aedffd18def7d8300eec4637e330/log4j-core/src/main/java/org/apache

Re: Build fails in Master

2022-01-31 Thread Ralph Goers
I’m not sure what all that means Matt. After I changed the import for core.config.plugins to just plugins the build ran fine. So PluginAliases are working, provided they use the annotation from the plugins module. They just don’t work when using the annotation from core, which should work to

Re: Build fails in Master

2022-01-31 Thread Matt Sicker
Aliases aren't yet supported in the new DI system (well, the new-new-DI system; the BeanManager version did have support for aliases). There's an alias lookup strategy thing defined on the plugins.PluginAliases annotation that might be missing on the core version. On Mon, Jan 31, 2022 at 12:49 PM

Re: Build fails in Master

2022-01-31 Thread Ralph Goers
And nevermind again. The PluginAliases moved to the plugins module. I changed that and those tests are now fine. However, that does point out a problem that any log4j 2 plugin with pluginAliases is not going to work in log4j 3.0. We need to fix that. Ralph > On Jan 31, 2022, at 11:44 AM, Ralph

Re: Build fails in Master

2022-01-31 Thread Ralph Goers
I see. In release-2.x PatternLayout is annotated with @PluginAliases, one of which is EnhancedPatternLayout. Master also has that annotation but it is marked deprecated. Matt, did you break that annotation? Ralph > On Jan 31, 2022, at 11:35 AM, Ralph Goers wrote: > > Gary, > > I would reall

Re: Build fails in Master

2022-01-31 Thread Ralph Goers
Gary, I would really like to know how you tested https://github.com/apache/logging-log4j2/pull/708. It references EnhancedPatternLayout which is not present in the PR. Ralph > On Jan 31, 2022, at 5:01 AM, Gary Gregory wrote: > > Hi All, > > The branch master started to fail to build for me

Re: Build fails in Master

2022-01-31 Thread Matt Sicker
That test failure is likely genuine. On Mon, Jan 31, 2022 at 6:02 AM Gary Gregory wrote: > > Hi All, > > The branch master started to fail to build for me probably a week ago, but > it was not faliing for anyone else. I suspect my slow mac mini might have > been a factor in my failure as Matt's a

Re: Build fails in Master

2022-01-31 Thread Gary Gregory
Hi All, The branch master started to fail to build for me probably a week ago, but it was not faliing for anyone else. I suspect my slow mac mini might have been a factor in my failure as Matt's analysis points the finger at a timing issue in plugin/loading concurrent code combined with the fact t

Build fails in Master

2022-01-30 Thread Ralph Goers
I just pulled master and am unable to build it. [INFO] Running org.apache.log4j.config.PropertiesConfigurationTest 2022-01-30 22:39:47,046 main ERROR Unable to create Layout org.apache.log4j.EnhancedPatternLayout due to ClassNotFoundException:org.apache.log4j.EnhancedPatternLayout [ERROR] Tests